Disable /login path for roles with role_type oidc #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vault must not accept signed JWT tokens through /login path when role has role_type oidc, since there might be a situation when the client secret could be compromised, and thus the malicious might be able to illegitimately get a token with the right aud claim, which Vault would accept through the /login path.
|
|
|
@bks7 Thanks for the PR. I think your suggestion makes sense. The current approach was in support of a Kubernetes use case that isn't needed at this point, so removing this ability is fine. I plan to get to the review soon. |
kalafut
approved these changes
Apr 4, 2019
|
Thanks! |
kalafut
pushed a commit
that referenced
this pull request
Jun 18, 2019
This check was inadvertently removed for OIDC roles in #38
Merged
kalafut
pushed a commit
that referenced
this pull request
Jun 18, 2019
This check was incorrectly removed for OIDC roles in #38
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vault must not accept signed JWT tokens through /login path when role
has role_type oidc, since there might be a situation when the client
secret could be compromised, and thus the malicious might be able to
illegitimately get a token with the right aud claim, which Vault would
accept through the /login path.