Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore client_id check #54

Merged
merged 1 commit into from
Jun 18, 2019
Merged

Restore client_id check #54

merged 1 commit into from
Jun 18, 2019

Conversation

kalafut
Copy link
Contributor

@kalafut kalafut commented Jun 18, 2019 •
edited
Loading

This check was incorrectly removed for OIDC roles in #38.

The PR also includes a test for this case and some general test cleanup.

Restore client_id check
4fe6b82 
This check was inadvertently removed for OIDC roles in
#38
tyrannosaurus-becks
tyrannosaurus-becks approved these changes Jun 18, 2019
View reviewed changes
Copy link
Contributor

@tyrannosaurus-becks tyrannosaurus-becks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, though of course the compilation error will need to be solved first. Looks like possibly a dependency issue?

jefferai
jefferai approved these changes Jun 18, 2019
View reviewed changes
Copy link
Member

@jefferai jefferai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@kalafut kalafut merged commit 407df2d into master Jun 18, 2019
@kalafut kalafut deleted the client-id-check branch June 18, 2019 22:31
@kalafut
Copy link
Contributor Author

kalafut commented Jun 18, 2019

This looks good, though of course the compilation error will need to be solved first. Looks like possibly a dependency issue?

travis hiccup, I guess. I just press rebuild and it was fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jefferai jefferai jefferai approved these changes

@tyrannosaurus-becks tyrannosaurus-becks tyrannosaurus-becks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kalafut @jefferai @tyrannosaurus-becks