always show secrets tab in the main nav (#6477)

* always show secrets tab in the main nav * remove secrets key from permissions service
hashicorp · Mar 26, 2019 · 9ba0372 · 9ba0372
1 parent c232d3f
commit 9ba0372
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 28 deletions.
diff --git a/ui/app/services/permissions.js b/ui/app/services/permissions.js
@@ -2,7 +2,6 @@ import Service, { inject as service } from '@ember/service';
 import { task } from 'ember-concurrency';
 
 const API_PATHS = {
-  secrets: { engine: 'cubbyhole/' },
   access: {
     methods: 'sys/auth',
     entities: 'identity/entities',

diff --git a/ui/app/templates/vault/cluster.hbs b/ui/app/templates/vault/cluster.hbs
@@ -17,18 +17,16 @@
             </NamespacePicker>
           </li>
         {{/if}}
-        {{#if (has-permission 'secrets')}}
-          <li class="{{if (is-active-route 'vault.cluster.secrets') 'is-active'}}">
-            {{#link-to
-              "vault.cluster.secrets"
-              current-when="vault.cluster.secrets vault.cluster.settings.mount-secret-backend vault.cluster.settings.configure-secret-backend"
-              invokeAction=(action Nav.closeDrawer)
-              data-test-navbar-item='secrets'
-            }}
-              Secrets
-            {{/link-to}}
-          </li>
-        {{/if}}
+        <li class="{{if (is-active-route 'vault.cluster.secrets') 'is-active'}}">
+          {{#link-to
+            "vault.cluster.secrets"
+            current-when="vault.cluster.secrets vault.cluster.settings.mount-secret-backend vault.cluster.settings.configure-secret-backend"
+            invokeAction=(action Nav.closeDrawer)
+            data-test-navbar-item='secrets'
+          }}
+            Secrets
+          {{/link-to}}
+        </li>
         {{#if (has-permission 'access')}}
           <li class="{{if (is-active-route 'vault.cluster.access') 'is-active'}}">
             {{#link-to

diff --git a/ui/tests/acceptance/cluster-test.js b/ui/tests/acceptance/cluster-test.js
@@ -39,21 +39,6 @@ module('Acceptance | cluster', function(hooks) {
     await logout.visit();
   });
 
-  test('shows nav item if user does have permission', async function(assert) {
-    const read_secrets_policy = `'
-      path "cubbyhole/" {
-        capabilities = ["read"]
-      },
-    '`;
-
-    const userToken = await tokenWithPolicy('show-secrets-nav', read_secrets_policy);
-    await logout.visit();
-    await authPage.login(userToken);
-
-    assert.dom('[data-test-navbar-item=secrets]').exists();
-    await logout.visit();
-  });
-
   test('enterprise nav item links to first route that user has access to', async function(assert) {
     const read_rgp_policy = `'
       path "sys/policies/rgp" {