Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always show secrets tab in the main nav #6477

Merged
merged 2 commits into from
Mar 26, 2019
Merged

Conversation

meirish
Copy link
Contributor

@meirish meirish commented Mar 26, 2019

Currently we rely on access to cubbyhole to show the secrets tab, but this isn't a very good indicator if users have access to secrets. Instead, we're just going to always show the secrets nav item and the API call will filter mounts appropriately (the API we use will only return mounts they have access to).

To test:

  1. Create a policy w/o access to cubbyhole - path "secret*" { capabilities = [ "read" ] }
  2. Create a token with that policy
  3. Log in to the UI with that new token
  4. Verify that Secrets still shows up in the main navigation

@meirish meirish added this to the 1.1.1 milestone Mar 26, 2019
@meirish meirish requested review from a team March 26, 2019 12:42
Copy link
Contributor

@madalynrose madalynrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logged right into the secrets page with cubbyhole ^_^

@meirish meirish merged commit 9ba0372 into master Mar 26, 2019
@meirish meirish deleted the ui-nav-always-show-secrets branch March 26, 2019 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants