-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing word "database" in docs #12274
Conversation
Add missing word database
Add missing "database" keyword.
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes 1 out of 2 committers have signed the CLA.
Have you signed the CLA already but the status is still pending? Recheck it. |
Will check with employer on respective terms in the CLA. |
Hi @tvsaru - were you able to get clarity on whether you'll be able to sign the CLA? Please let me know how we can help. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably should say "a SQL database" versus "an SQL database".
@klaporte, the debate about should SQL use "a" or "an" as the indefinite article seems to be confusing everyone. My confusion came from the fact that when I say SQL I say the letters separately, and end up using "an" for the same reason noted in https://oracle-base.com/blog/2015/01/02/a-sql-or-an-sql/. In this context, at least when writing I am going to take your suggestion and use 'a'. -- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Based on our company policies I need to push this change via Bloomberg fork, as we have a corporate level agreement for the CLA. Will do that next week. Thanks for your patience. |
Hey @tvsaru ! Did you maybe end up creating a separate PR for this change ? Was wondering if this one should be closed out. |
Issued PR #13571 via |
SQL is the language and based on second bullet point the author probably intended SQL "database".