Add missing word "database" in docs #13571
Conversation
Add missing word database
Add missing "database" keyword.
|
|
|
@tvsaru for a corporate CLA, make sure that your GitHub handle matches what's in the CLA, and that your organization affiliation is publicly viewable. Thanks! :) |
|
@hsimon-hashicorp I opened my profile in incognito mode and I see the following:
^ it shows I am part of @bloomberg org. Does that meet the requirements you noted? |
|
That satisfies one part of the bot, yes - but if your GitHub handle is different than what was provided in the corporate CLA, or you were added to the org after the CLA was signed, the bot might not be able to pick up on that. Can you check with your CLA signers to make sure you're included in the list? Thanks! :) |
|
Oh I see. What I was looking at before was the employer field. I followed GitHub doc to make my @bloomberg membership public. Lets see if that is enough for @hashicorp-cla bot.
|
|
@hsimon-hashicorp I asked the bot to recheck and LGTM now:
|
|
Huzzah! Teamwork for the win. Thanks @tvsaru for your patience there. :) |
|
Thank @hsimon-hashicorp & @taoism4504. When will this get merged? |
|
@tvsaru I've kicked the tests that are failing, and will keep an eye on it. "Sometime today" is when I expect this to be merged. :) |
Co-authored-by: Loann Le <84412881+taoism4504@users.noreply.github.com>
|
Hi @tvsaru - can you merge in main on this PR? It'll fix the automated test failures. I'm trying to work out an update to our process to not require some of these tests for docs-only changes, as well. Thanks in advance! |
|
Sorry for the inconvenience @hsimon-hashicorp I should have rebased before issuing the new PR. Merged upstream/main into my branch now, 🤞🏽 |
|
@hsimon-hashicorp there is still one test failing:
Maybe a flaky test?
|
|
That's one of our flakier tests, and doesn't block the merge. Thanks again for this PR! :) |
* Update README.md Add missing word database * Update what-is-vault.mdx Add missing "database" keyword. * Update README.md * Update what-is-vault.mdx * Update website/content/docs/what-is-vault.mdx * Update website/content/docs/what-is-vault.mdx Co-authored-by: Loann Le <84412881+taoism4504@users.noreply.github.com> Co-authored-by: Loann Le <84412881+taoism4504@users.noreply.github.com>
SQL is the language and based on second bullet point the author probably intended SQL "database".
Original PR #12274 , issuing this new PR via
bloombergorg to leverage the company level CLA between Hashicorp and Bloomberg and also to comply with our internal policies on how to contribute to open source repos.