secrets/azure: add changelog for rotate-root #13034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvoran
reviewed
Nov 3, 2021
| @@ -0,0 +1,3 @@ | |||
| ```release-note:improvement | |||
There was a problem hiding this comment.
I wonder if the changelog file should be named for the PR that updated the dep? i.e. 12975.txt
There was a problem hiding this comment.
Ah yes, it'd be good to have that reference. Would it fail the CI check though since it won't match to this PR's number?
There was a problem hiding this comment.
Referenced in the PR, keeping it the same due to CI failures.
tvoran
approved these changes
Nov 3, 2021
jasonodonnell
added a commit
that referenced
this pull request
Nov 3, 2021
* secrets/azure: add changelog for rotate-root * Rename changelog file * Use PR number as filename
jasonodonnell
added a commit
that referenced
this pull request
Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a missing changelog in 1.9 for Azure secrets rotate root: hashicorp/vault-plugin-secrets-azure#70.
The azure secrets plugin was updated in the PR to Vault: #12975.