Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

secrets/azure: add changelog for rotate-root #13034

Merged
merged 3 commits into from
Nov 3, 2021
Merged

secrets/azure: add changelog for rotate-root #13034

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c709858
secrets/azure: add changelog for rotate-root
jasonodonnell Nov 3, 2021
f2e32f3
Rename changelog file
jasonodonnell Nov 3, 2021
3031d00
Use PR number as filename
jasonodonnell Nov 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog/13034.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:improvement
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if the changelog file should be named for the PR that updated the dep? i.e. 12975.txt

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, it'd be good to have that reference. Would it fail the CI check though since it won't match to this PR's number?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Referenced in the PR, keeping it the same due to CI failures.

secrets/azure: Adds support for rotate-root. [#70](https://github.com/hashicorp/vault-plugin-secrets-azure/pull/70)
```