Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Fix blank secret on KV create > cancel #22541

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

hashishaw
Copy link
Contributor

Before this change, if you click "cancel" on the "create secret" form in KV, a ghost secret would appear on the list when you return to the list view:

Screenshot 2023-08-23 at 5 24 06 PM

In even older versions, this would cause the page to render a completely blank screen.

@hashishaw hashishaw added ui bug Used to indicate a potential bug backport/1.12.x labels Aug 23, 2023
@hashishaw hashishaw added this to the 1.15 milestone Aug 23, 2023
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Aug 23, 2023
Copy link
Contributor

@kiannaquach kiannaquach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎊 love the one-liners!

@hashishaw hashishaw enabled auto-merge (squash) August 23, 2023 22:40
@hashishaw hashishaw merged commit 0f8bde7 into main Aug 23, 2023
97 checks passed
@hashishaw hashishaw deleted the ui/VAULT-16333/fix-blank-row-on-exit-create branch August 23, 2023 22:45
@github-actions
Copy link

Build Results:
All builds succeeded! ✅

@github-actions
Copy link

CI Results:
All Go tests succeeded! ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Used to indicate a potential bug hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants