Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of UI: Fix blank secret on KV create > cancel into release/1.14.x #22544

Conversation

hc-github-team-secure-vault-core
Copy link
Contributor

Backport

This PR is auto-generated from #22541 to be assessed for backporting due to the inclusion of the label backport/1.14.x.

The below text is copied from the body of the original PR.


Before this change, if you click "cancel" on the "create secret" form in KV, a ghost secret would appear on the list when you return to the list view:

Screenshot 2023-08-23 at 5 24 06 PM

In even older versions, this would cause the page to render a completely blank screen.


Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/ui/VAULT-16333/fix-blank-row-on-exit-create/officially-robust-shrew branch from ca9e895 to d94a6fb Compare August 23, 2023 22:46
@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/ui/VAULT-16333/fix-blank-row-on-exit-create/officially-robust-shrew branch from 12f16db to 01de264 Compare August 23, 2023 22:46
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Aug 23, 2023
@hashishaw hashishaw added this to the 1.14.2 milestone Aug 23, 2023
@hashishaw hashishaw enabled auto-merge (squash) August 23, 2023 23:01
@github-actions
Copy link

Build Results:
All builds succeeded! ✅

@hashishaw hashishaw merged commit fc1297b into release/1.14.x Aug 23, 2023
90 of 92 checks passed
@hashishaw hashishaw deleted the backport/ui/VAULT-16333/fix-blank-row-on-exit-create/officially-robust-shrew branch August 23, 2023 23:07
@github-actions
Copy link

CI Results:
All Go tests succeeded! ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants