Cancel context only after response body is read #4979
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briankassouf
approved these changes
Jul 23, 2018
ebilling
suggested changes
Jul 24, 2018
There was a problem hiding this comment.
Inside the RawRequest function, moving the cancelFunc is helpful, but it would be much better to refactor the code into another function and call it from within the loop, then you could set up your context and defer the cancelFunc call while making the code much easier to read. This is a long method. I tested it with my use case that had empty Body but set content-lengths on cancels, and this does pass my test.
|
Closing in favor of #4987 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4973