Fix vet warnings. #5816
Closed
Fix vet warnings. #5816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -689,7 +689,9 @@ START: | |||
| } | |||
|
|
|||
| if timeout != 0 { | |||
| ctx, _ = context.WithTimeout(ctx, timeout) | |||
| var cancel context.CancelFunc | |||
| ctx, cancel = context.WithTimeout(ctx, timeout) | |||
There was a problem hiding this comment.
IIRC, this was done intentionally. I wish there was a comment explaining why but maybe we should test this out before we merge it.
There was a problem hiding this comment.
Thanks for pointing that out. You're right: back in #4987 you removed an existing call to the cancelfunc that was already there. Some background is given in #4973 and #4979, where the idea of doing it in a defer was discussed. It looks like that approach was rejected because of @jefferai 's comment that
The problem with deferring is that we support retries so these could pile up
but that confuses me because there's at best a single retry in this scope (namely, when redirectCount==0).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this change
make vetno longer generates output.