Remove DEL characters from password input #5837
Conversation
iTerm password manager sends \x03\0x7f before sending a password from its password manager to make sure the password is not being echoed to the screen. Unfortunately, vault login does not handle the Space DEL sequence, causing the login to fail when using the password manager. This patch uses a simple method to delete the sequence if present anywhere in the string, although it is strictly only needed at the start of input.
|
I don't follow the logic here. Why aren't you just doing a trimprefix with that exact substring? |
|
The logic is to search for the first instance of the \x7f character, and remove it and the preceding character, then loop to see if there are any other instances. If there are no instances found, return the current string. There may be more elegant ways to acomplish the task, but this is the way I came up with. While I could just TrimPrefix, this felt like a more complete solution which would handle DEL in other areas of the password, or if iTerm would change the preceding space (\x03) to some other character in the future. |
|
Considering what iterm is doing here is special purpose and rather bogus, I think we should just handle it explicitly. That way if other cases come up we can handle them knowingly. |
The logic now only removes the two byte prefix sent in by iTerm instead of trying to remove all deletes in the string. This has been tested to work with the iTerm password manager. As a small correction, the byte sequence is \x20\x7f. The earlier commit message incorrectly stated it was \x03\x7f.
|
@jefferai: I have simplified the code to only handle the iTerm sequence by using TrimPrefix. This has been tested using the iTerm Password Manager. |
iTerm password manager sends \x03\x7f before sending a password
from its password manager to make sure the password is not being
echoed to the screen. Unfortunately, vault login does not handle
the Space DEL sequence, causing the login to fail when using the
password manager. This patch uses a simple method to delete the
sequence if present anywhere in the string, although it is strictly
only needed at the start of input.
This can be tested by using the iTerm built-in password manager, the
passwords entered from the password manager are not accepted by
vault. The first two characters are \x03\x7f.
After the patch, the \x7f character is removed as well as the preceding
character. If the \x7f character is the first on the line, only that
character is deleted.