Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DEL characters from password input #5837

Merged
merged 3 commits into from
Dec 12, 2018

Commits on Nov 23, 2018

  1. Remove DEL characters from password input

    iTerm password manager sends \x03\0x7f before sending a password
    from its password manager to make sure the password is not being
    echoed to the screen.  Unfortunately, vault login does not handle
    the Space DEL sequence, causing the login to fail when using the
    password manager.  This patch uses a simple method to delete the
    sequence if present anywhere in the string, although it is strictly
    only needed at the start of input.
    thorhs committed Nov 23, 2018
    Configuration menu
    Copy the full SHA
    c98cfa2 View commit details
    Browse the repository at this point in the history
  2. Simplify iTerm handling to only remove iTerm prefix

    The logic now only removes the two byte prefix sent in by iTerm
    instead of trying to remove all deletes in the string.
    
    This has been tested to work with the iTerm password manager.
    
    As a small correction, the byte sequence is \x20\x7f.  The
    earlier commit message incorrectly stated it was \x03\x7f.
    thorhs committed Nov 23, 2018
    Configuration menu
    Copy the full SHA
    587f109 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2018

  1. Configuration menu
    Copy the full SHA
    c40c042 View commit details
    Browse the repository at this point in the history