-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for older hardware #5
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derezzedex
force-pushed
the
dev/arm-support
branch
from
December 15, 2021 12:56
985ab92
to
5e79377
Compare
hecrj
force-pushed
the
dev/arm-support
branch
from
December 17, 2021 10:15
50e8b2b
to
a14d2ce
Compare
hecrj
approved these changes
Dec 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is perfect! Great work 🎉
I have made a couple of small changes:
- Updated
glutin
to0.28
, as I wasn't able to run the examples with the older version. - Updated
glow
to0.11.1
, which already contains the changes in ExposeVersion
and addContext::version
grovesNL/glow#196 🎉 - Updated the
CHANGELOG
to only mention the changes that are important to end-users.
The integration
workflow is failing on the beta
toolchain because of an issue on winit
and some changes in the linking strategy of Rust (see rust-windowing/winit#2078).
In any case, I think we can 🚢 !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add support for older hardware, depends on grovesNL/glow#196.
Should close #4.
Changes
For this, this PR does a couple of things:
core
andcompatibility
.I've also:
Pipeline::get_max_texture_size
(which had aTODO
)CHANGELOG.md
Core and Compatibility
The main idea here is to separate the
core
pipeline, which is preferred and used on hardware that supports it and thecompatibility
pipeline which is the fallback, used on hardware that doesn't have the features needed forcore
.Right now, the main thing separating them is the support for instancing, this means that
core
uses instancing whilecompatibility
uses a vertex and index buffer.Feedback
I think the separation between the
core
andcompatibility
could be improved to reduce code duplication and futher changes/maintenance easier. Any feedback and testing is appreciated.