Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): fix missing dockerfile error #2988

Merged
merged 3 commits into from
Aug 23, 2024

Conversation

eablack
Copy link
Contributor

@eablack eablack commented Aug 23, 2024

Fixes #1420

Description

This resolves a bug where if you specify multiple process types in container:push --recursive and one of those dockerfiles doesn't actually exist, you get a bad error.

Testing

  1. Pull down this branch and yarn build
  2. Go to a directory where a docker-based app is set up
  3. Have Dockerfile.web in the directory, but not Dockerfile.worker
  4. run $CLI_PATH/bin/run container:push web worker --recursive
  5. See warning message instead of error

@eablack eablack requested a review from a team as a code owner August 23, 2024 16:35
@eablack eablack merged commit 1f880e8 into main Aug 23, 2024
8 checks passed
@eablack eablack deleted the eb/fix-missing-process-error-with-docker branch August 23, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

heroku container:push --recursive: improve error message
2 participants