Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): fix missing dockerfile error #2988

Merged
merged 3 commits into from
Aug 23, 2024
Merged

fix(cli): fix missing dockerfile error #2988

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d9c5ea
Warn users of not found process types
eablack Aug 22, 2024
3028fb0
Warn if process type doesn't exist
eablack Aug 22, 2024
322b285
Add test for missing dockerfile
eablack Aug 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/cli/src/lib/container/docker_helper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import * as glob from 'glob'
import * as Path from 'path'
import * as inquirer from 'inquirer'
import * as os from 'os'
import {ux} from '@oclif/core'

const DOCKERFILE_REGEX = /\bDockerfile(.\w*)?$/

Expand Down Expand Up @@ -140,6 +141,11 @@ export const chooseJobs = async function (jobs: groupedDockerJobs) {
for (const processType in jobs) {
if (Object.prototype.hasOwnProperty.call(jobs, processType)) {
const group = jobs[processType]
if (group === undefined) {
ux.warn(`Dockerfile.${processType} not found`)
continue
}

if (group.length > 1) {
const prompt = [{
type: 'list',
Expand Down
Loading