Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: re-enable linters and improve code quality #836

Closed
jooola opened this issue Aug 9, 2024 · 0 comments · Fixed by #866
Closed

refactor: re-enable linters and improve code quality #836

jooola opened this issue Aug 9, 2024 · 0 comments · Fixed by #866
Labels
refactor test

Comments

@jooola
Copy link
Member

jooola commented Aug 9, 2024

TL;DR

The golanglint-ci configuration has a lot of disabled linters. We must enable the linters again to keep improving the quality of the codebase.

I recommend re-enabling a single linter at the time to prevent a massive PR hard to review.

Expected behavior

All the linters are enabled, and the code passes linting.
@phm07 phm07 mentioned this issue Aug 12, 2024
Merged
phm07 added a commit that referenced this issue Aug 22, 2024
@phm07
refactor: enable & enforce linter rules (#840)
15b26d6 
See #836
@phm07 phm07 changed the title Re-enable linters and improve code quality refactor: re-enable linters and improve code quality Aug 30, 2024
@phm07 phm07 mentioned this issue Sep 9, 2024
Merged
phm07 added a commit that referenced this issue Sep 12, 2024
@phm07
refactor: re-enable linters, use presets (#866)
42d0c82 
This PR updates the linting rules, disabling old, unused ones and now
using presets for less clutter.
This file was used as a starting point:
https://github.com/apricote/releaser-pleaser/blob/main/.golangci.yaml

Closes #836
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: re-enable linters, use presets hetznercloud/cli
1 participant
@jooola