Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: re-enable linters, use presets #866

Merged
merged 3 commits into from
Sep 12, 2024
Merged

refactor: re-enable linters, use presets #866

merged 3 commits into from
Sep 12, 2024

Conversation

phm07
Copy link
Contributor

@phm07 phm07 commented Sep 6, 2024

This PR updates the linting rules, disabling old, unused ones and now using presets for less clutter.
This file was used as a starting point: https://github.com/apricote/releaser-pleaser/blob/main/.golangci.yaml

Closes #836

Base automatically changed from image-label-key-suggestions to main September 9, 2024 10:11
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 47.54098% with 32 lines in your changes missing coverage. Please review.

Project coverage is 61.47%. Comparing base (b6aecb3) to head (7d4f8f0).

Files with missing lines Patch % Lines
internal/cmd/server/create.go 0.00% 10 Missing ⚠️
internal/testutil/testing.go 0.00% 6 Missing ⚠️
internal/cmd/server/describe.go 0.00% 3 Missing ⚠️
internal/state/state.go 0.00% 3 Missing ⚠️
internal/cmd/firewall/add_rule.go 0.00% 2 Missing ⚠️
internal/cmd/firewall/create.go 0.00% 2 Missing ⚠️
internal/cmd/server/ssh.go 33.33% 2 Missing ⚠️
internal/state/config/options.go 0.00% 2 Missing ⚠️
internal/cmd/base/update.go 0.00% 1 Missing ⚠️
internal/cmd/server/enable_rescue.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #866      +/-   ##
==========================================
- Coverage   61.49%   61.47%   -0.03%     
==========================================
  Files         238      238              
  Lines        8529     8532       +3     
==========================================
  Hits         5245     5245              
- Misses       2575     2578       +3     
  Partials      709      709              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phm07 phm07 self-assigned this Sep 9, 2024
@phm07 phm07 added the refactor label Sep 9, 2024
@phm07 phm07 marked this pull request as ready for review September 9, 2024 10:21
@phm07 phm07 requested a review from a team as a code owner September 9, 2024 10:21
@phm07 phm07 merged commit 42d0c82 into main Sep 12, 2024
5 checks passed
@phm07 phm07 deleted the linting branch September 12, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: re-enable linters and improve code quality
2 participants