Upgrade to use OpenTelemetry version 0.13.0 #95
Conversation
|
Note that open-telemetry/opentelemetry-go-contrib#399 tracks the less-than-ideal span hierarchy created by the example client's HTTP requests. |
| global.SetTextMapPropagator(otel.NewCompositeTextMapPropagator( | ||
| propagators.TraceContext{}, | ||
| propagators.Baggage{})) | ||
| return bsp.Shutdown |
There was a problem hiding this comment.
See open-telemetry/opentelemetry-specification#1073 for how this situation might change soon. My comment open-telemetry/opentelemetry-specification#1073 (comment) addresses my use of NewBatchSpanProcessor above, as opposed to using WithBatcher.
There was a problem hiding this comment.
open-telemetry/opentelemetry-go#1227 just merged, allowing shutting down a TracerProvider, in trun shutting down its registered span processors. Once we have release available that includes that new method, I'll propose an update to simplify this example.
|
Just had to close/re-open to trigger CI 👍 |
Adapt the Honeycomb OpenTelemetry exporter to use the OpenTelemetry opentelemetry-go and opentelemetry-go-contrib libraries as of their coordinated releases at version 0.13.0.
Update the example client and server programs to demonstrate use of trace propagation, including baggage. For the server program, augment it to accept its listening address and port as command-line flags, use an HTTP handler multiplexer to accommodate additional URL paths, and to shut down cleanly upon receiving INT and TERM signals.
While we're here, address all complaints from golint, go vet, and staticcheck.