This repository has been archived by the owner on Dec 20, 2021. It is now read-only.
Transcribe attributes from span links to events #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that this patch is stacked on top of #95, but GitHub won't allow me to represent that properly here. |
seh
force-pushed
the
transcribe-span-link-attributes
branch
from
0ae0c34
to
db66e5d
Compare
Yes, it looks cleaner now. Please take another look. |
|
@seh Apologies for the hold up with this PR. If you would please rebase again I will make sure this gets reviewed promptly. 🙏 |
Links attached to OpenTelemetry spans carry attributes like spans and events. Since we publish links as Honeycomb events, and events all carry fields, transcribe attributes on links as fields on the corresponding Honeycomb events. Include OpenTelemetry resource attributes as the underlay, and shadow those resource attributes if necessary with the link-level attributes.
seh
force-pushed
the
transcribe-span-link-attributes
branch
from
db66e5d
to
9a2e994
Compare
This was a blast from the past. Please see the latest commit. |
|
|
||
| // Treat resource-defined attributes as underlays, with any same-keyed span attributes taking | ||
| // precedence. Apply them first. | ||
| applyResourceAttributes(ev) | ||
| if len(e.serviceName) != 0 { |
There was a problem hiding this comment.
Why remove adding service_nameto the event here?
There was a problem hiding this comment.
See lines 508-511 above. It still happens as part of the call to applyResourceAttributes at line 521.
asdvalenzuela
approved these changes
Dec 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links attached to OpenTelemetry spans carry attributes like spans and events. Since we publish links as Honeycomb events, and events all carry fields, transcribe attributes on links as fields on the corresponding Honeycomb events.
Include OpenTelemetry resource attributes as the underlay, and shadow those resource attributes if necessary with the link-level attributes, as we did for spans and span events in #71.