Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-6431 - Fix tldraw export to image functionality #4753

Merged
merged 3 commits into from
Feb 12, 2024

Conversation

davwas
Copy link
Contributor

@davwas davwas commented Feb 11, 2024

Description

QA note:
Change tested one env:
https://bc-6431-fix-export-functionality.nbc.dbildungscloud.dev/
The uploaded image can be exported, no issues found, but bug found that large image files over 17mb are not exported when using firefox. This is the problem tldraw has identified on the test site https://old.tldraw.com .

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/BC-6431
hpi-schul-cloud/tldraw-client#53

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@davwas davwas self-assigned this Feb 11, 2024
Copy link

sonarcloud bot commented Feb 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@davwas davwas enabled auto-merge (squash) February 12, 2024 08:46
@davwas davwas merged commit bcd2b92 into main Feb 12, 2024
45 of 47 checks passed
@davwas davwas deleted the BC-6431-fix-export-functionality branch February 12, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants