Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC-6431 - Fix tldraw export to image functionality #53

Merged
merged 13 commits into from
Feb 12, 2024
Merged

BC-6431 - Fix tldraw export to image functionality #53

merged 13 commits into from
Feb 12, 2024

Conversation

davwas
Copy link
Contributor

@davwas davwas commented Feb 7, 2024 •
edited
Loading

Description

This PR fixes exporting assets as svg/image formats.
We needed to copy and change some tldraw functionality to fix exporting assets that are stored in external storage.

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/BC-6431
hpi-schul-cloud/schulcloud-server#4753

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Screenshots of UI changes

Approval for review

  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@davwas davwas added the WIP This feature branch is in progress, do not merge it. label Feb 7, 2024
@davwas davwas self-assigned this Feb 7, 2024
wiaderwek
wiaderwek reviewed Feb 7, 2024
View reviewed changes
src/utils/exportUtils.ts Outdated Show resolved Hide resolved
src/utils/exportUtils.ts Outdated Show resolved Hide resolved
@davwas davwas removed the WIP This feature branch is in progress, do not merge it. label Feb 7, 2024
CeEv
CeEv requested changes Feb 8, 2024
View reviewed changes
src/utils/imageExportUtils.ts Outdated Show resolved Hide resolved
src/utils/imageExportUtils.ts Outdated Show resolved Hide resolved
@davwas davwas requested a review from CeEv February 8, 2024 13:52
@davwas
Merge branch 'main' into BC-6431-fix-export-functionality
82b02a1 
# Conflicts:
#	src/components/Editor.tsx
#	src/hooks/useMultiplayerState.ts
@davwas
fix conflicts
9ab8dea
@davwas
format comment
ca2d4dc
@davwas
Merge branch 'main' into BC-6431-fix-export-functionality
dc620ac 
# Conflicts:
#	src/components/Editor.tsx
#	src/hooks/useMultiplayerState.ts
@davwas
add image export error handling
b26f959
@davwas
fix formatting
2c024cc
@davwas davwas mentioned this pull request Feb 11, 2024
Merged
3 tasks
@davwas davwas merged commit 71f253f into main Feb 12, 2024
26 of 27 checks passed
@davwas davwas deleted the BC-6431-fix-export-functionality branch February 12, 2024 09:03
CeEv
CeEv requested changes Feb 12, 2024
View reviewed changes
src/hooks/useMultiplayerState.ts Show resolved Hide resolved
src/hooks/useMultiplayerState.ts Show resolved Hide resolved
@CeEv
Copy link

CeEv commented Feb 12, 2024

I make my review for the merge, but forgett the submit.
Plase look to my comments. If you change a lot after a review, please request the reviewer again before you merge it.

@davwas davwas restored the BC-6431-fix-export-functionality branch February 12, 2024 13:09
@davwas davwas deleted the BC-6431-fix-export-functionality branch February 12, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CeEv CeEv CeEv requested changes

@wiaderwek wiaderwek wiaderwek approved these changes

Assignees

@davwas davwas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davwas @CeEv @wiaderwek