55-scsi-sg3_id.rules: removal of scsi_id, and cleanup #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hannes, it's been two weeks ... could you voice an opinion on this patch set? It would certainly be beneficial for the systemd pull request to have this one accepted first. If you disagree with my changes, could you give me directions what to modify? |
hreinecke
requested changes
Dec 23, 2017
hreinecke
approved these changes
Dec 23, 2017
hreinecke
approved these changes
Dec 23, 2017
|
Sigh. Github doesn't make for a nice patch-by-patch review.
|
|
Hannes, this is a github "feature", see why are my commits in the wrong order? and isaacs/github#386. If you look at the patches in the actual commit order "compat" is introduced in |
|
Hannes, I've sent you the patches by e-mail. Ping for review... |
Reviewed-by: Hannes Reinecke <hare@suse.com>
|
Updated the set of commits after Hannes' review. The current set has been tested for tapes too, using https://github.com/markh794/mhvtl. |
mwilck
force-pushed
the
master
branch
3 times, most recently
from
69dceaa
to
b9081d2
Compare
Restore compatibility with scsi_id by truncating ID_WWN to 16 chars. ID_WWN_WITH_EXTENSION is what actually matters for SCSI, but we should get this right nevertheless.
Separate the "compat" rules for creating ID_* variables from SCSI_* variables from the block doing actual inquiry. Also improve code readability by spelling out the sysfs vs. sg code more clearly. This patch should have no functional impact.
In order to replace scsi_id functionality from udev's 60-persistent-storage.rules, add code for non-SCSI devices that support sg INQUIRY (only CCISS at this time). CCISS has been deprecated since Linux 4.14, but these rules are supposed to work with older kernels, too.
In order to replace scsi_id functionality in udev's 60-persistent-storage.rules, add support for some non-block devices. These rules have been tested using the emulated virtual tape library mhVTL (https://github.com/markh794/mhvtl). It turns out that preferring sysfs attributes for inquiry is even more beneficial for those than for disks.
ata_id or usb_id may have already set these variables. Don't overwrite them in this case.
scsi_id sets ID_TARGET_PORT=%x.
As of 2018 kernel 4.15, the kernel doesn't provide VPD pages for "SPC" devices (SCSI version 0x03, ANSI INCITS 301-1997) in sysfs. It's usually safe to try though (no counter-example is known), and for scsi_id compatibility, we have to try. If the kernel ever changes its policy, this rule can perhaps be dropped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've attempted a rewrite of systemd's 60-persistent-storage.rules, with the following goals:
(this implies changes in 55-sg3-utils.rules)
symlink creation
lines, thus less conditions individual rules, thus more GOTOs
separating blocks of code where certain conditins are known to
hold.
This is the sg3_utils part. I also submitted a pull request for systemd:
systemd/systemd#7594