Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

55-scsi-sg3_id.rules: removal of scsi_id, and cleanup #22

Merged
merged 8 commits into from
Feb 7, 2018

Commits on Jan 24, 2018

  1. 55-scsi-sg3_id.rules: fix SCSI_IDENT_LUN_NAA_EXT case

    Reviewed-by: Hannes Reinecke <hare@suse.com>
    mwilck committed Jan 24, 2018
    Configuration menu
    Copy the full SHA
    f9d39ee View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2018

  1. 55-scsi-sg3_id.rules: ID_WWN has max 16 characters

    Restore compatibility with scsi_id by truncating ID_WWN to 16 chars.
    ID_WWN_WITH_EXTENSION is what actually matters for SCSI, but we
    should get this right nevertheless.
    mwilck committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    5d943a0 View commit details
    Browse the repository at this point in the history
  2. 55-scsi-sg3_id.rules: reorder compat and sysfs/sg_inq rules

    Separate the "compat" rules for creating ID_* variables from
    SCSI_* variables from the block doing actual inquiry.
    
    Also improve code readability by spelling out the sysfs vs. sg
    code more clearly. This patch should have no functional impact.
    mwilck committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    a59e4f1 View commit details
    Browse the repository at this point in the history
  3. 55-scsi-sg3_id.rules: support for legacy CCISS devices

    In order to replace scsi_id functionality from udev's
    60-persistent-storage.rules, add code for non-SCSI devices that support sg
    INQUIRY (only CCISS at this time). CCISS has been deprecated since Linux 4.14,
    but these rules are supposed to work with older kernels, too.
    mwilck committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    98b04c1 View commit details
    Browse the repository at this point in the history
  4. 55-scsi-sg3_id.rules: Support tapes and medium changers

    In order to replace scsi_id functionality in udev's
    60-persistent-storage.rules, add support for some non-block devices.
    
    These rules have been tested using the emulated virtual tape library
    mhVTL (https://github.com/markh794/mhvtl). It turns out that preferring
    sysfs attributes for inquiry is even more beneficial for those than
    for disks.
    mwilck committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    cdc4233 View commit details
    Browse the repository at this point in the history
  5. 55-scsi-sg3_id.rules: don't overwrite MODEL_ID etc.

    ata_id or usb_id may have already set these variables.
    Don't overwrite them in this case.
    mwilck committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    8be170d View commit details
    Browse the repository at this point in the history
  6. 55-scsi-sg3_id.rules: compat support for ID_TARGET_PORT

    scsi_id sets ID_TARGET_PORT=%x.
    mwilck committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    8b375d8 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2018

  1. 55-scsi-sg3_utils.rules: run sg_inq for SPC devices

    As of 2018 kernel 4.15, the kernel doesn't provide VPD pages for "SPC" devices
    (SCSI version 0x03, ANSI INCITS 301-1997) in sysfs. It's usually safe to try
    though (no counter-example is known), and for scsi_id compatibility, we have
    to try. If the kernel ever changes its policy, this rule can perhaps be dropped.
    mwilck committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    7df3633 View commit details
    Browse the repository at this point in the history