Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build config and optimizations #1769

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

VIKTORVAV99
Copy link
Contributor

Changes the BABEL_ENV from jsnext to ESNext which should give the intended effects for es modules, this allows const functions to be used more without breaking the optimisations.

It also changes the targets and libs in tsconfig to match the minimum version needed for optional chaining to function (ES2020).

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • commit message and code follows the Developer's Certification of Origin

@adrai
Copy link
Member

adrai commented Jul 16, 2024

still failing :-(

Copy link

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Install scripts npm/fsevents@1.2.13
  • Install script: install
  • Source: node install.js
🚫

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/fsevents@1.2.13

@coveralls
Copy link

Coverage Status

coverage: 97.206% (-0.005%) from 97.211%
when pulling 6ecee8d on VIKTORVAV99:build_config_and_optimizations
into 34aa20d on i18next:master.

@adrai adrai merged commit 08ba6ae into i18next:master Jul 16, 2024
6 of 9 checks passed
@marcalexiei marcalexiei mentioned this pull request Jul 16, 2024
4 tasks
@adrai
Copy link
Member

adrai commented Jul 16, 2024

still failing :-(

@VIKTORVAV99 #1773

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants