Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(types): fix broken tests #1773

Merged
merged 1 commit into from
Jul 16, 2024
Merged

test(types): fix broken tests #1773

merged 1 commit into from
Jul 16, 2024

Conversation

marcalexiei
Copy link
Member

@marcalexiei marcalexiei commented Jul 16, 2024 •
edited
Loading

After #1768 typescript tests are broken:

Applied the same configuration of i18next (i18next/i18next#2210)

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • commit message and code follows the Developer's Certification of Origin

@adrai adrai merged commit 0338bf1 into i18next:master Jul 16, 2024
8 checks passed
@coveralls
Copy link

Coverage Status

coverage: 97.206%. remained the same
when pulling b33bf8a on marcalexiei:fix-broken-ts-tests
into 08ba6ae on i18next:master.

@marcalexiei marcalexiei deleted the fix-broken-ts-tests branch July 16, 2024 16:20
@adrai adrai mentioned this pull request Jul 16, 2024
Merged
4 tasks
@marcalexiei
Copy link
Member Author

I posted the wrong PR, actually the issues was introduced by the previous PR: #1768.

Warning

Both #1768 and #1769 have type checking tests failing.

@adrai You should consider to setup GitHub branch protection rule to prevent merge if some of the checks are failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcalexiei @coveralls @adrai