Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

valueOf of date with with setted utcOffset does not work properly #809

Closed
veksa opened this issue Feb 28, 2020 · 2 comments · Fixed by #872
Closed

valueOf of date with with setted utcOffset does not work properly #809

veksa opened this issue Feb 28, 2020 · 2 comments · Fixed by #872
Labels
☢️Bug Something isn't working released

Comments

@veksa
Copy link

veksa commented Feb 28, 2020 •
edited
Loading

Describe the bug
valueOf of date with with setted utcOffset does not work properly

Expected behavior

dayjs('2017-07-20T11:00:00+00:00').utcOffset(-12).startOf('day').valueOf()

should equal to

moment('2017-07-20T11:00:00+00:00').utcOffset(-12).startOf('day').valueOf()

and be 1500465600000

Information

  • Day.js Version v1.8.21
  • OS: Windows
  • Browser Chrome 80
  • Time zone: GMT+02:00
@iamkun iamkun added the ☢️Bug Something isn't working label Feb 29, 2020
@PengJiyuan
Copy link

+1

iamkun added a commit that referenced this issue Apr 17, 2020
@iamkun
fix: Fix UTC plugin startOf, endOf bug
7ae636f 
fix #809, fix #808
@iamkun iamkun mentioned this issue Apr 17, 2020
Merged
iamkun added a commit that referenced this issue Apr 17, 2020
@iamkun
fix: Fix UTC plugin startOf, endOf bug (#872)
4141084 
fix #809, fix #808
iamkun pushed a commit that referenced this issue Apr 21, 2020
@semantic-release-bot
chore(release): 1.8.25 [skip ci]
bcea067 
## [1.8.25](v1.8.24...v1.8.25) (2020-04-21)

### Bug Fixes

* Fix CustomParseFormat plugin of parsing only YYYY / YYYY-MM bug ([#873](#873)) ([3cea04d](3cea04d)), closes [#849](#849)
* Fix Duration plugin get seconds ([#867](#867)) ([62b092d](62b092d))
* Fix type definition of locale ([9790b85](9790b85))
* Fix UTC plugin startOf, endOf bug ([#872](#872)) ([4141084](4141084)), closes [#809](#809) [#808](#808)
@iamkun
Copy link
Owner

iamkun commented Apr 21, 2020

🎉 This issue has been resolved in version 1.8.25 🎉

The release is available on:

Your semantic-release bot 📦🚀

andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this issue May 10, 2022
@andrewhood125ruhuc
chore(release): 1.8.25 [skip ci]
04a5513 
## [1.8.25](iamkun/dayjs@v1.8.24...v1.8.25) (2020-04-21)

### Bug Fixes

* Fix CustomParseFormat plugin of parsing only YYYY / YYYY-MM bug ([#873](iamkun/dayjs#873)) ([3cea04d](iamkun/dayjs@3cea04d)), closes [#849](iamkun/dayjs#849)
* Fix Duration plugin get seconds ([#867](iamkun/dayjs#867)) ([62b092d](iamkun/dayjs@62b092d))
* Fix type definition of locale ([9790b85](iamkun/dayjs@9790b85))
* Fix UTC plugin startOf, endOf bug ([#872](iamkun/dayjs#872)) ([4141084](iamkun/dayjs@4141084)), closes [#809](iamkun/dayjs#809) [#808](iamkun/dayjs#808)
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this issue May 10, 2022
@andrewhood125ruhuc
chore(release): 1.8.25 [skip ci]
004d863 
## [1.8.25](iamkun/dayjs@v1.8.24...v1.8.25) (2020-04-21)

### Bug Fixes

* Fix CustomParseFormat plugin of parsing only YYYY / YYYY-MM bug ([#873](iamkun/dayjs#873)) ([3cea04d](iamkun/dayjs@3cea04d)), closes [#849](iamkun/dayjs#849)
* Fix Duration plugin get seconds ([#867](iamkun/dayjs#867)) ([62b092d](iamkun/dayjs@62b092d))
* Fix type definition of locale ([9790b85](iamkun/dayjs@9790b85))
* Fix UTC plugin startOf, endOf bug ([#872](iamkun/dayjs#872)) ([4141084](iamkun/dayjs@4141084)), closes [#809](iamkun/dayjs#809) [#808](iamkun/dayjs#808)
allmoviestvshowslistsfilmography28 added a commit to allmoviestvshowslistsfilmography28/dayjs that referenced this issue Sep 12, 2024
@allmoviestvshowslistsfilmography28 @semantic-release-bot
chore(release): 1.8.25 [skip ci]
5bfa931 
## [1.8.25](iamkun/dayjs@v1.8.24...v1.8.25) (2020-04-21)

### Bug Fixes

* Fix CustomParseFormat plugin of parsing only YYYY / YYYY-MM bug ([#873](iamkun/dayjs#873)) ([a4a819a](iamkun/dayjs@a4a819a)), closes [#849](iamkun/dayjs#849)
* Fix Duration plugin get seconds ([#867](iamkun/dayjs#867)) ([6250c5e](iamkun/dayjs@6250c5e))
* Fix type definition of locale ([b975659](iamkun/dayjs@b975659))
* Fix UTC plugin startOf, endOf bug ([#872](iamkun/dayjs#872)) ([22696aa](iamkun/dayjs@22696aa)), closes [#809](iamkun/dayjs#809) [#808](iamkun/dayjs#808)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
☢️Bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Fix UTC plugin startOf, endOf bug iamkun/dayjs
3 participants
@veksa @iamkun @PengJiyuan