Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix Duration plugin get seconds #867

Merged
merged 1 commit into from
Apr 17, 2020
Merged

Conversation

iamkun
Copy link
Owner

@iamkun iamkun commented Apr 15, 2020

fix #865


IssueHunt Summary

IssueHunt has been backed by the following sponsors. Become a sponsor

@codecov
Copy link

codecov bot commented Apr 15, 2020

Codecov Report

Merging #867 into dev will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev      #867   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          164       164           
  Lines         1319      1323    +4     
  Branches       273       274    +1     
=========================================
+ Hits          1319      1323    +4     
Impacted Files Coverage Δ
src/plugin/duration/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3188e15...7d46954. Read the comment docs.

@iamkun iamkun merged commit 62b092d into dev Apr 17, 2020
@iamkun iamkun deleted the fix/duration-get-seconds branch April 17, 2020 08:17
iamkun pushed a commit that referenced this pull request Apr 21, 2020
## [1.8.25](v1.8.24...v1.8.25) (2020-04-21)

### Bug Fixes

* Fix CustomParseFormat plugin of parsing only YYYY / YYYY-MM bug ([#873](#873)) ([3cea04d](3cea04d)), closes [#849](#849)
* Fix Duration plugin get seconds ([#867](#867)) ([62b092d](62b092d))
* Fix type definition of locale ([9790b85](9790b85))
* Fix UTC plugin startOf, endOf bug ([#872](#872)) ([4141084](4141084)), closes [#809](#809) [#808](#808)
@iamkun
Copy link
Owner Author

iamkun commented Apr 21, 2020

🎉 This PR is included in version 1.8.25 🎉

The release is available on:

Your semantic-release bot 📦🚀

andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
## [1.8.25](iamkun/dayjs@v1.8.24...v1.8.25) (2020-04-21)

### Bug Fixes

* Fix CustomParseFormat plugin of parsing only YYYY / YYYY-MM bug ([#873](iamkun/dayjs#873)) ([3cea04d](iamkun/dayjs@3cea04d)), closes [#849](iamkun/dayjs#849)
* Fix Duration plugin get seconds ([#867](iamkun/dayjs#867)) ([62b092d](iamkun/dayjs@62b092d))
* Fix type definition of locale ([9790b85](iamkun/dayjs@9790b85))
* Fix UTC plugin startOf, endOf bug ([#872](iamkun/dayjs#872)) ([4141084](iamkun/dayjs@4141084)), closes [#809](iamkun/dayjs#809) [#808](iamkun/dayjs#808)
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
## [1.8.25](iamkun/dayjs@v1.8.24...v1.8.25) (2020-04-21)

### Bug Fixes

* Fix CustomParseFormat plugin of parsing only YYYY / YYYY-MM bug ([#873](iamkun/dayjs#873)) ([3cea04d](iamkun/dayjs@3cea04d)), closes [#849](iamkun/dayjs#849)
* Fix Duration plugin get seconds ([#867](iamkun/dayjs#867)) ([62b092d](iamkun/dayjs@62b092d))
* Fix type definition of locale ([9790b85](iamkun/dayjs@9790b85))
* Fix UTC plugin startOf, endOf bug ([#872](iamkun/dayjs#872)) ([4141084](iamkun/dayjs@4141084)), closes [#809](iamkun/dayjs#809) [#808](iamkun/dayjs#808)
allmoviestvshowslistsfilmography28 added a commit to allmoviestvshowslistsfilmography28/dayjs that referenced this pull request Sep 12, 2024
## [1.8.25](iamkun/dayjs@v1.8.24...v1.8.25) (2020-04-21)

### Bug Fixes

* Fix CustomParseFormat plugin of parsing only YYYY / YYYY-MM bug ([#873](iamkun/dayjs#873)) ([a4a819a](iamkun/dayjs@a4a819a)), closes [#849](iamkun/dayjs#849)
* Fix Duration plugin get seconds ([#867](iamkun/dayjs#867)) ([6250c5e](iamkun/dayjs@6250c5e))
* Fix type definition of locale ([b975659](iamkun/dayjs@b975659))
* Fix UTC plugin startOf, endOf bug ([#872](iamkun/dayjs#872)) ([22696aa](iamkun/dayjs@22696aa)), closes [#809](iamkun/dayjs#809) [#808](iamkun/dayjs#808)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dayjs.duration(x.diff(y)) 后获取seconds()返回大于59
1 participant