fix(flink): quote SQL identifiers indiscriminately #7605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepyaman
force-pushed
the
fix/flink/base-identifiers
branch
3 times, most recently
from
bb10e78
to
969b9d7
Compare
deepyaman
commented
Nov 22, 2023
pyproject.toml
Outdated
| @@ -376,7 +376,7 @@ show_deps = true | |||
| [tool.codespell] | |||
| # local codespell matches `./docs`, pre-commit codespell matches `docs` | |||
| skip = "*.lock,.direnv,.git,./docs/_freeze,docs/_freeze/**,*.svg,*.css,*.html,*.js" | |||
| ignore-regex = '\b(i[if]f|I[IF]F|AFE)\b' | |||
| ignore-regex = '\b(i[if]f|I[IF]F|AFE|inout)\b' | |||
There was a problem hiding this comment.
Would be great if inline ignores were supported since "inout" seems like a very possible typo in most cases), but they're not.
deepyaman
commented
Nov 22, 2023
| @@ -1215,7 +1215,7 @@ def test_first_last(backend): | |||
| raises=com.OperationNotDefinedError, | |||
| reason="not support by the backend", | |||
| ) | |||
| @pytest.mark.notyet(["flink"], raises=Py4JJavaError, reason="not supported by Flink") | |||
| @pytest.mark.broken(["flink"], raises=Py4JJavaError, reason="bug in Flink") | |||
There was a problem hiding this comment.
There were two issues here:
timeis a reserved keyword- Even then, there seems to be an issue: https://apache-flink.slack.com/archives/C03G7LJTS2G/p1700675938430139
The stack trace on the second results in:
Caused by: org.apache.flink.util.FlinkRuntimeException: org.apache.flink.api.common.InvalidProgramException: Table program cannot be compiled. This is a bug. Please file an issue.
I'm still discussing with somebody on the Flink side; may update later with a Jira ref.
deepyaman
commented
Nov 22, 2023
deepyaman
commented
Nov 22, 2023
| @@ -14,9 +14,11 @@ def format_call(translator, func, *args): | |||
| return "{}({})".format(func, ", ".join(formatted_args)) | |||
|
|
|||
|
|
|||
| def quote_identifier(name, quotechar="`", force=False): | |||
| def quote_identifier( | |||
| name, quotechar="`", force=False, base_identifiers=identifiers.base_identifiers | |||
There was a problem hiding this comment.
I was going to name it reserved_keywords, but I think Flink's set is actually reserved + unreserved keywords. So I left it as base_identifiers.
deepyaman
force-pushed
the
fix/flink/base-identifiers
branch
3 times, most recently
from
e8e344b
to
29c20d1
Compare
deepyaman
changed the title
deepyaman
changed the title
cpcloud
approved these changes
Nov 28, 2023
cpcloud
added
bug
deepyaman
force-pushed
the
fix/flink/base-identifiers
branch
from
29c20d1
to
5f1ab00
Compare
|
(I intentionally haven't squashed, to leave the reference for customizing identifiers, but just let me know if would like me to before merging.) |
|
No need to squash! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to update the list for Flink (ran into a couple of issues today, with
TIMEandVALUE).