Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Unit tests in Python 3.5 #177

Closed
dortegau opened this issue Apr 12, 2020 · 0 comments
Closed

Fixing Unit tests in Python 3.5 #177

dortegau opened this issue Apr 12, 2020 · 0 comments
Assignees
Labels

Comments

@dortegau
Copy link
Member

Prerequisites

Description

As Python does not guarantee dict order, unit tests intermittently fails because from Python 3.6 onwards, the standard dict type maintains insertion order by default (that's why never fails using Python >= 3.6).

Steps to Reproduce

  1. Execute unit tests multiple times using Python 3.5

Expected behavior: Tests should pass always

Actual behavior: Tests sometimes fails

Reproduces how often: Not determined

Versions

Prom2teams v2.5.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant