Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#175 Using multi-stage build to create prom2teams image #176

Merged
merged 5 commits into from
Apr 13, 2020
Merged

#175 Using multi-stage build to create prom2teams image #176

merged 5 commits into from
Apr 13, 2020

Conversation

dortegau
Copy link
Member

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions
  • Remember to set idealista:develop as base branch;

Description of the Change

Benefits

That change reduces image complexity (now doesn't included unused source code) and resultant image size.

Possible Drawbacks

AFAIK there aren't possible drawbacks

Applicable Issues

#175

@dortegau
Copy link
Member Author

dortegau commented Apr 12, 2020 •
edited
Loading

#177 Should be merged first (fixes unit tests under Python 3.5.x)

@dortegau dortegau requested a review from juanriaza April 12, 2020 21:30
@dortegau dortegau merged commit 4732a5e into develop Apr 13, 2020
@dortegau dortegau deleted the features/175 branch April 13, 2020 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frantsao frantsao frantsao approved these changes

@jmonterrubio jmonterrubio jmonterrubio approved these changes

@sorobon sorobon sorobon approved these changes

@blalop blalop blalop approved these changes

@caldito caldito caldito approved these changes

@jperera jperera Awaiting requested review from jperera

@Thasselhof Thasselhof Awaiting requested review from Thasselhof

@juanriaza juanriaza Awaiting requested review from juanriaza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dortegau @frantsao @jmonterrubio @sorobon @blalop @caldito