feat: add options to http client #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rafaelramalho19
commented
Mar 31, 2021
•
rafaelramalho19
commented
- Adds support for extra options to be passed down to ipfs-http-client.
- Related issues/prs:
- IPLD Explorer error: Invalid version, must be a number equal to 1 or 0 ipfs/ipfs-webui#1726
- chore: update dependencies and ipld ipfs/ipld-explorer-components#287
- chore: update ipld explorer components ipfs/ipfs-webui#1750
Also, better online check, and more flexible way of passing httpClient configuration object. License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
lidel
force-pushed
the
feat/add-options-to-http-client
branch
2 times, most recently
from
b94dee8
to
e125b96
Compare
License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
lidel
force-pushed
the
feat/add-options-to-http-client
branch
from
e125b96
to
685e059
Compare
License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
lidel
approved these changes
Apr 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.