chore: update dependencies and ipld #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 1, 2021
License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
The accent color is already used for raw leaves in the d3 graph, this makes sure we remove confusion between git-raw and raw License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
lidel
force-pushed
the
chore/update-ipld-and-deps
branch
from
29502c3
to
d72adbc
Compare
License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
IPFS publishing is broken atm and does not seem to be very useful in this repo anyway – actual website is build at https://github.com/ipfs/explore.ipld.io License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
This aims to match changes that happened in ipfs-webui over past year. License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
lidel
approved these changes
Apr 2, 2021
There was a problem hiding this comment.
Thank you @rafaelramalho19 for untangling this mess ❤️
LGTM, added small cosmetic fixes and chores:
- multihash-as-hex was broken due to type change in js-ipfs
- bumped i18next stack to match ipfs-webui
- bumped some deps related to cid decoding just in case
- fixed CI
lidel
added a commit
that referenced
this pull request
Apr 12, 2021
This PR partially reverts #287 because `/api/v0/dag` in go-ipfs do not implement latest IPLD features yet, and ipfs-http-client delegates path traversal and resolution to go-ipfs, so codecs in JS are never used. By reverting to standalone js-ipld we decouple IPLD explorer from what is available in go-ipfs – we simply fetch raw block and do all decoding the old way, in JS. We will revisit this in the future, after IPLD Prime work lands in go-ipfs, but for now this is the only way to fix IPLD Explorer to work against go-ipfs backend. License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
lidel
added a commit
that referenced
this pull request
Apr 12, 2021
This PR partially reverts #287 because `/api/v0/dag` in go-ipfs do not implement latest IPLD features yet, and ipfs-http-client delegates path traversal and resolution to go-ipfs, so codecs in JS are never used. By reverting to standalone js-ipld we decouple IPLD explorer from what is available in go-ipfs – we simply fetch raw block and do all decoding the old way, in JS. We will revisit this in the future, after IPLD Prime work lands in go-ipfs, but for now this is the only way to fix IPLD Explorer to work against go-ipfs backend.
olizilla
reviewed
Apr 23, 2021
Comment on lines
+22
to
+23
| 'git-raw': { shortName: 'GIT', name: 'Git', color: '#378085' }, | ||
| 'raw': { shortName: 'RAW', name: 'Raw Block', color: '#f14e32' }, // eslint-disable-line quote-props |
There was a problem hiding this comment.
the color for git-raw gets swapped for raw here. @lidel @rafaelramalho19
There was a problem hiding this comment.
This was intentional: we used the same accent for git and raw blocks, and raw ones are way more important in CIDv1 world (used for leaves).
I want to add raw and dag-cbor examples (ipld/explore.ipld.io#62 (comment)), but had no bandwidth for that, so for now only ensured we remove confusion between git and raw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@loadable/componentto match webui next releaseNotes