fix: status and cid are strings in the query result #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The types expect `status` and `cid` to be arrays of strings, but they arrive as strings so the code fails. Instead of using multiple query args we use a single are with multiple values delimited by commas. Problem is this seems to be broken in oas-tools at the moment: oas-tools/oas-tools#248 This PR works around the breakage.
lidel
approved these changes
Apr 4, 2022
There was a problem hiding this comment.
LGTM, thanks!
fwiw the spec seems to do the right thing, but tooling is scuffed – I filled ipfs-shipyard/pinning-service-compliance#14 to ensure we have tests for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The types expect
statusandcidto be arrays of strings, but they arrive as strings so the code fails.Instead of using multiple query args we use a single are with multiple values delimited by commas. This should work if you specify
style: formandexplode: falsein your service def but this seems to be broken in oas-tools at the moment: oas-tools/oas-tools#248This PR works around the breakage.