Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

fix: exclude fs from bundle #4076

Merged
merged 8 commits into from
Apr 5, 2022
Merged

fix: exclude fs from bundle #4076

merged 8 commits into from
Apr 5, 2022

Conversation

achingbrain
Copy link
Member

@achingbrain achingbrain commented Apr 4, 2022

We used to have 'fs' in our dep tree via ora via mock-ipfs-pinning-service but that seems to have changed.

We only want to import 'fs' during node tests but esbuild tries to resolve it, so add the dummy fs package as a dev dep to the affected packages.

We used to have 'fs' in our dep tree via ora via mock-ipfs-pinning-service
but that seems to have changed.

We only want to import 'fs' during node tests but esbuild tries to resolve
it, so make the import dynamic.
@achingbrain
Copy link
Member Author

@achingbrain achingbrain changed the title fix: fix build fix: exclude fs from bundle Apr 5, 2022
@achingbrain achingbrain merged commit 6c3cb73 into master Apr 5, 2022
@achingbrain achingbrain deleted the fix/fix-build branch April 5, 2022 14:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant