fix(gw): widen duration histograms and cleanup #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
force-pushed
the
fix/gateway-metrics
branch
from
b8d766f
to
6e1d7a4
Compare
lidel
added a commit
to ipfs-inactive/bifrost-gateway
that referenced
this pull request
Apr 5, 2023
lidel
commented
Apr 5, 2023
7 tasks
Codecov Report
@@ Coverage Diff @@
## main #265 +/- ##
==========================================
- Coverage 48.08% 48.05% -0.04%
==========================================
Files 270 270
Lines 33064 33030 -34
==========================================
- Hits 15900 15871 -29
+ Misses 15493 15491 -2
+ Partials 1671 1668 -3
|
hacdias
approved these changes
Apr 6, 2023
lidel
added a commit
to ipfs-inactive/bifrost-gateway
that referenced
this pull request
Apr 6, 2023
Includes ipfs/boxo#265 ipfs/boxo#272 Closes #77
lidel
added a commit
to ipfs-inactive/bifrost-gateway
that referenced
this pull request
Apr 6, 2023
Includes ipfs/boxo#265 ipfs/boxo#272 Closes #77
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
fix: widens the duration histogram by adding buckets that cover durations between 1-30 minutes (geometric progression, closes remaining issues from Fix CAR and other metrics ipfs-inactive/bifrost-gateway#76)
cleanup: removes deprecated and unused legacy histograms: after feat: refactor gateway api to operate on higher level semantics #176 and feat(gateway): IPFSBackend metrics and HTTP range support #245 we now have api_call_duration_seconds histograms for higher resolution info per backend operation