fix(gateway): panic on path without enough components #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hacdias
commented
Apr 6, 2023
| {"127.0.0.1:8080", "/" + k.Cid().String(), http.StatusNotFound, "404 page not found\n"}, | ||
| {"127.0.0.1:8080", "/ipfs/this-is-not-a-cid", http.StatusBadRequest, "failed to resolve /ipfs/this-is-not-a-cid: invalid path \"/ipfs/this-is-not-a-cid\": invalid CID: invalid cid: illegal base32 data at input byte 3\n"}, |
There was a problem hiding this comment.
ℹ️ This changes slightly because the path is validated earlier than before.
Codecov Report
@@ Coverage Diff @@
## main #272 +/- ##
==========================================
+ Coverage 47.98% 48.01% +0.03%
==========================================
Files 270 270
Lines 33030 33034 +4
==========================================
+ Hits 15850 15862 +12
+ Misses 15504 15499 -5
+ Partials 1676 1673 -3
|
lidel
added a commit
to ipfs-inactive/bifrost-gateway
that referenced
this pull request
Apr 6, 2023
Includes ipfs/boxo#265 ipfs/boxo#272 Closes #77
lidel
added a commit
to ipfs-inactive/bifrost-gateway
that referenced
this pull request
Apr 6, 2023
Includes ipfs/boxo#265 ipfs/boxo#272 Closes #77
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes ipfs-inactive/bifrost-gateway#77. During the refactors we changed the way we resolved paths and introduced
getPathRoots. I could have added this fix there. However, I decided to check for its validity earlier up.