Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: use subtle for XORing bytes #379

Merged
merged 1 commit into from
Sep 27, 2023
Merged

util: use subtle for XORing bytes #379

merged 1 commit into from
Sep 27, 2023

Conversation

Jorropo
Copy link
Contributor

@Jorropo Jorropo commented Jun 26, 2023

Fixes #377

@Jorropo Jorropo requested a review from a team as a code owner June 26, 2023 13:14
@Jorropo Jorropo enabled auto-merge (rebase) June 26, 2023 13:15
@Jorropo Jorropo disabled auto-merge June 26, 2023 13:16
@Jorropo
Copy link
Contributor Author

Jorropo commented Jun 26, 2023

Revisit when updating to go1.21

@Jorropo Jorropo added the status/blocked Unable to be worked further until needs are met label Jun 26, 2023
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #379 (ec910c3) into main (56861d6) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #379      +/-   ##
==========================================
+ Coverage   66.41%   66.48%   +0.06%     
==========================================
  Files         207      207              
  Lines       24692    24692              
==========================================
+ Hits        16400    16416      +16     
+ Misses       6866     6852      -14     
+ Partials     1426     1424       -2     
Files Coverage Δ
util/util.go 33.33% <100.00%> (ø)

... and 15 files with indirect coverage changes

@Jorropo Jorropo added skip/changelog and removed status/blocked Unable to be worked further until needs are met labels Sep 27, 2023
@Jorropo Jorropo enabled auto-merge (rebase) September 27, 2023 08:15
util/util.go Show resolved Hide resolved
@hacdias hacdias enabled auto-merge (rebase) September 27, 2023 08:25
@hacdias hacdias merged commit c34473b into main Sep 27, 2023
13 checks passed
@hacdias hacdias deleted the fix/377 branch September 27, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

util: Optimize XOR
2 participants