Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: use subtle for XORing bytes #379

Merged
merged 1 commit into from
Sep 27, 2023
+4 −3
Merged

util: use subtle for XORing bytes #379

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions util/util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
package util

import (
"crypto/subtle"
"errors"
"io"
"math/rand"
Expand Down Expand Up @@ -150,9 +151,9 @@ func IsValidHash(s string) bool {

// XOR takes two byte slices, XORs them together, returns the resulting slice.
func XOR(a, b []byte) []byte {
_ = b[len(a)-1] // keeping same behaviour as previously but this looks like a bug
hacdias marked this conversation as resolved.
Show resolved Hide resolved

c := make([]byte, len(a))
for i := 0; i < len(a); i++ {
c[i] = a[i] ^ b[i]
}
subtle.XORBytes(c, a, b)
return c
}