Skip to content
This repository has been archived by the owner on Aug 1, 2023. It is now read-only.

test: add mfs interop tests #25

Merged
merged 1 commit into from
Aug 24, 2018
Merged

test: add mfs interop tests #25

merged 1 commit into from
Aug 24, 2018

Conversation

achingbrain
Copy link
Member

Requires mfs to be merged into js-ipfs first..

@ghost ghost assigned achingbrain Jul 4, 2018
@ghost ghost added the status/in-progress In progress label Jul 4, 2018
@achingbrain
Copy link
Member Author

Needs the following merging first:

ipfs-inactive/js-ipfs-http-client#805
ipfs/js-ipfs#1360

Copy link
Member

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm getting some intermittent pubsub failures which are obviously unrelated

@ghost ghost assigned daviddias Jul 12, 2018
@daviddias
Copy link
Member

Failing on Windows

image

@daviddias
Copy link
Member

Also on Mac OS X with the same error.

  1) files does not error when creating the same directory twice and -p is passed:

     Error: file already exists

      at parseError (node_modules/ipfs-api/src/utils/send-request.js:17:17)

      at ClientRequest.<anonymous> (node_modules/ipfs-api/src/utils/send-request.js:47:14)

      at HTTPParser.parserOnIncomingClient (_http_client.js:546:21)

      at HTTPParser.parserOnHeadersComplete (_http_common.js:109:17)

      at Socket.socketOnData (_http_client.js:432:20)

      at addChunk (_stream_readable.js:283:12)

      at readableAddChunk (_stream_readable.js:264:11)

      at Socket.Readable.push (_stream_readable.js:219:10)

      at TCP.onread (net.js:635:20)

@daviddias daviddias removed their assignment Jul 12, 2018
@achingbrain
Copy link
Member Author

These are regressions caused by me trying to improve error message compatibility with go. It will need ipfs/js-ipfs#1439 merging & releasing first.

@achingbrain achingbrain force-pushed the add-mfs-interop-tests branch 4 times, most recently from 613252b to c125d02 Compare July 13, 2018 13:46
@achingbrain
Copy link
Member Author

Those have been merged & released so this should be good to go, although now I think #23 is causing everything to catch fire ☹️

@alanshaw
Copy link
Member

  1) files has the same hashes for small files with CIDv1:
      AssertionError: expected 'zb2rhiNedvrkpYhcrgtpmhKk5UPzcgizgSXaQLYXNY745BmYP' to deeply equal 'zdj7WcDSFNSsZkdkbpSDGeLsBtHbYKyvPQsaw6PpeeYdGqoAx'

All of the files tests are now passing for me when run with this PR to ipfs-unixfs-engine ipfs-inactive/js-ipfs-unixfs-engine#228

@achingbrain achingbrain merged commit 0c1bcf9 into master Aug 24, 2018
@ghost ghost removed the status/in-progress In progress label Aug 24, 2018
@achingbrain achingbrain deleted the add-mfs-interop-tests branch August 24, 2018 09:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants