Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

chore: update mfs dep to make interop tests pass #1439

Merged
merged 1 commit into from
Jul 14, 2018
Merged

Conversation

achingbrain
Copy link
Member

The new version updates the error messages to be the same as go, and fixes the case where mkdiring an existing directory with the -p option should not cause an error to occur.

@ghost ghost assigned achingbrain Jul 13, 2018
@ghost ghost added the status/in-progress In progress label Jul 13, 2018
package.json Outdated
@@ -108,7 +108,7 @@
"ipfs-block": "~0.7.1",
"ipfs-block-service": "~0.14.0",
"ipfs-http-response": "~0.1.2",
"ipfs-mfs": "~0.0.16",
"ipfs-mfs": "~0.0.17",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please release a minor version. Seems that the error message changed and that should be considered a breaking change.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I should have done that ages ago:

How should I deal with revisions in the 0.y.z initial development phase?

The simplest thing to do is start your initial development release at 0.1.0 and then increment the minor version for each subsequent release.

Copy link
Member

@daviddias daviddias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error changes are breaking changes

@alanshaw alanshaw merged commit 2982ee7 into master Jul 14, 2018
@ghost ghost removed the status/in-progress In progress label Jul 14, 2018
@alanshaw alanshaw deleted the update-mfs-dep branch July 14, 2018 13:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants