Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

refactor: use unixfs exporter with CID instances #1902

Merged
merged 8 commits into from
Mar 18, 2019

Conversation

alanshaw
Copy link
Member

@alanshaw alanshaw commented Feb 27, 2019

Allows IPFS to use the unixfs exporter that exports CID instances without API changes.

Next step is to get the unixfs importer to do the same and then make a breaking interface JS IPFS core API change to ensure we're always returning CID instances not strings for add, ls etc etc.

refs ipfs-inactive/interface-js-ipfs-core#394

Depends on:

@ghost ghost assigned alanshaw Feb 27, 2019
@ghost ghost added the status/in-progress In progress label Feb 27, 2019
package.json Outdated Show resolved Hide resolved
Copy link
Member

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alanshaw alanshaw marked this pull request as ready for review March 18, 2019 12:10
@ghost ghost assigned achingbrain Mar 18, 2019
alanshaw and others added 8 commits March 18, 2019 17:51
Allows IPFS to use the unixfs exporter that exports CID instances _without_ API changes.

refs ipfs-inactive/interface-js-ipfs-core#394

Depends on:

* [ ] ipfs-inactive/js-ipfs-mfs#44
* [ ] ipfs-inactive/js-ipfs-unixfs-exporter#19

License: MIT
Signed-off-by: Alan Shaw <alan@tableflip.io>
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
Co-Authored-By: alanshaw <alan.shaw@protocol.ai>
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
@alanshaw alanshaw force-pushed the refactor/use-exporter-w-cid-instances branch from 16d1670 to 9d4102e Compare March 18, 2019 17:56
@alanshaw alanshaw merged commit b841f1c into master Mar 18, 2019
@alanshaw alanshaw deleted the refactor/use-exporter-w-cid-instances branch March 18, 2019 18:59
@ghost ghost removed the status/in-progress In progress label Mar 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants