routing: rework interfaces to make separation easier #3107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Jeromy <why@ipfs.io>
|
Yeah, seems on the right track to break Peer Routing and Content Routing into separate parts, so that we can have other types of Content Routing (therefore super fast providing) See https://github.com/libp2p/interface-record-store and https://github.com/libp2p/interface-peer-routing also for more context. |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've started to work on separating the content routing layer and the peer routing layer. The third bit that we glom into our current routing interface deals with direct values, i think thats what @diasdavid was starting to call the record store, but i'm not sure its the same scope. Definitely want some feedback here.
cc @jbenet @diasdavid
License: MIT
Signed-off-by: Jeromy why@ipfs.io