Code Review v0.4.4...v0.4.5

[ghost]

Reflects c99a82d

Notable changes

• IPLD and CIDs
  • Rework go-ipfs to use content IDs version 0 -- Rework go-ipfs to use content IDs version 0 #3187
  • The conquest of El Cid, Pt. 2 -- The conquest of El Cid, Pt. 2 #3290
  • Turn merkledag.Node into an interface -- Turn merkledag.Node into an interface #3301
  • Implement cbor ipld nodes and a first pass at the 'dag' command -- Implement cbor ipld nodes and a first pass at the 'dag' command #3325
  • allow cid format selection in block put command -- allow cid format selection in block put command #3324
  • cmd/block: add selection of multihash parameters to block put command -- cmd/block: add selection of multihash parameters to block put command #3483
  • bitswap: protocol extension to handle cids -- bitswap: protocol extension to handle cids #3297
  • Add dag and stat to command help info -- Add dag and stat to command help info #3422
  • dag get should be a read only command -- dag get should be a read only command #3499
  • dag/get: accept paths and not just cids -- dag/get: accept paths and not just cids #3517
  • ds-help: add helper functions to convert from Cid to DsKey and the reverse -- ds-help: add helper functions to convert from Cid to DsKey and the reverse #3310
  • Issue ipfs pin ls <hash> fetches the object from the network #3419: Do not recursively resolve DAG just to obtain a CID -- Issue #3419: Do not recursively resolve DAG just to obtain a CID #3420
  • merkledag: retain cid types when roundtripping through a ProtoNode -- merkledag: retain cid types when roundtripping through a ProtoNode #3443
  • Fix "ipfs ls" so it works correctly with raw leaves. -- Fix "ipfs ls" so it works correctly with raw leaves. #3557
• Raw Nodes
  • Implement 'Raw Node' node type -- Implement 'Raw Node' node type #3307
  • merkledag: optimize DagService GetLinks for Raw Nodes. -- merkledag: optimize DagService GetLinks for Raw Nodes. #3351
  • Fix panic in dagreader with raw nodes -- Fix panic in dagreader with raw nodes #3403
• Experimental PubSub
  • Add a very basic many to many pubsub -- Add a very basic many to many pubsub #3202
  • Send empty struct to pubsub cmd output to flush -- Send empty struct to pubsub cmd output to flush #3416
  • cmd/pubsub: fix peers command topic filtering -- cmd/pubsub: fix peers command topic filtering #3484
  • add sharness test for pubsub -- add sharness test for pubsub #3432
• Core API
  • gateway: use core api for serving GET/HEAD/POST -- gateway: use core api for serving GET/HEAD/POST #3244

changes

• gateway: disable Suborigins as it conflicts the spec -- gateway: disable Suborigins as it conflicts the spec #3519
• blockstore: rename RuntimeHashing to HashOnRead -- blockstore: rename RuntimeHashing to HashOnRead #3143
• ipfs/cat: disable auto-gc check -- ipfs/cat: disable auto-gc check #3100
• Revert Add Defaults to ipfs add / Fix default logic of --progress option -- Revert Add Defaults to ipfs add / Fix default logic of --progress option #3464

improvements

• bitswap: add ledger subcommand -- bitswap: add ledger subcommand #2852
• Add "ipfs block rm" command. -- Add "ipfs block rm" command. #2962
• add config option to disable bandwidth metrics -- add config option to disable bandwidth metrics #3381
• add experimental dht client mode flag -- add experimental dht client mode flag #3269
• reprovider: add config option to set reprovide interval -- reprovider: add config option to set reprovide interval #3101
• cmds: implement ipfs dht provide command -- cmds: implement ipfs dht provide command #3106
• allow listing of streams to connected peers -- allow listing of streams to connected peers #3352
• add option to enable go-multiplex experiment -- add option to enable go-multiplex experiment #3447
• basic keystore implementation -- basic keystore implementation #3472
• ipfs/add: make --local flag not write out providers -- ipfs/add: make --local flag not write out providers #3102
• dont buffer entire input for tar adds -- dont buffer entire input for tar adds #3334
• gateway: degrade error in gateway to log to reduce noise -- gateway: degrade error in gateway to log to reduce noise #2971
• datastore: blockstore should retry when it encounters temp errors -- datastore: blockstore should retry when it encounters temp errors #3091
• Adder: Don't hold the PinLock when not pinning. -- Adder: Don't hold the PinLock when not pinning. #3222
• cmd: validate repo/api file and print nicer error message -- cmd: validate repo/api file and print nicer error message #3219
• no longer hard code gomaxprocs -- no longer hard code gomaxprocs #3357
• bash_completion: Add a couple missing commands -- bash_completion: Add a couple missing commands #3369
• Updated Bash complete script -- Updated Bash complete script #3377
• blockstore: fix TODO and avoid calling ds.NewKey -- blockstore: fix TODO and avoid calling ds.NewKey #3379
• blockstore: remove expensive debug statement in AllKeysChan -- blockstore: remove expensive debug statement in AllKeysChan #3384
• Remove GC timeout, fix GC tests -- Remove GC timeout, fix GC tests #3494
• merkledag: add a concurrency limit to merkledag fetch graph -- merkledag: add a concurrency limit to merkledag fetch graph #3495
• "block rm": make channel large enough to avoid blocking -- "block rm": make channel large enough to avoid blocking #3418
• namesys: add entry to DHT cache after publish -- namesys: add entry to DHT cache after publish #3501
• namesys: fix case where there is no cache -- namesys: fix case where there is no cache #3509
• add in option to use nil-routing -- add in option to use nil-routing #3605
• "ipfs key list": include the hash of the key id in addition to the name -- "ipfs key list": include the hash of the key id in addition to the name #3581

bitswap

• bitswap: don't re-provide blocks we've provided very recently -- bitswap: don't re-provide blocks we've provided very recently #3105
• bitswap: add a deadline to sendmsg calls -- bitswap: add a deadline to sendmsg calls #3445
• cleanup bitswap and handle message send failure slightly better -- cleanup bitswap and handle message send failure slightly better #3408
• bitswap: increase wantlist resend delay to one minute -- bitswap: increase wantlist resend delay to one minute #3448
• bitswap: add wantlist fullness to protobuf messages -- bitswap: add wantlist fullness to protobuf messages #3461
• update message.proto with comments -- update message.proto #3476
• only pass keys down newBlocks chan in bitswap -- only pass keys down newBlocks chan in bitswap #3271
• Fix minor typo in bitswap debug logging -- Fix minor typo in bitswap debug logging #3178

fixes

• gateway: fix --writable flag :| -- gateway: fix --writable flag :| #3206
• unixfs: fix relative seek not expanding file properly -- unixfs: fix relative seek not expanding file properly  #3095
• use correct protocol names for ipfs services -- use correct protocol names for ipfs services #3132
• dht: add missing protocol ID to newStream call -- dht: add missing protocol ID to newStream call #3203
• namesys: return right after errors -- namesys: return right after errors #3345
• fuse: make osxfuse check config check more permissive -- fuse: make osxfuse check config check more permissive #3098
• fuse: Parse OSX fuse version properly -- fuse: Parse OSX fuse version properly #3413
• Fixes nc on macOS not closing socket when the stdin sends EOF -- Fixes nc on macOS not closing socket when the stdin sends EOF #3515
• commands: fix opt.Description panic when desc was empty -- commands: fix opt.Description panic when desc was empty #3521
• Fixes build: Unable to build with Go release candidates #3133: Properly handle release candidates in version comparison -- Fixes #3133: Properly handle release candidates in version comparison #3136
• "block rm": move core functionally into blockstore_util package -- "block rm": move core functionally into blockstore_util package #3225
• Don't drop error in readStreamedJson. -- Don't drop error in readStreamedJson. #3276
• cmd/ipfs: error out on invalid routing option -- cmd/ipfs: error out on invalid routing option #3482
• respect contexts when returning diagnostics responses -- respect contexts when returning diagnostics responses #3353
• fix formatting on error call -- fix formatting on error call #3435
• merkledag: fix json marshalling of pbnode -- merkledag: fix json marshalling of pbnode #3507
• rewrite enumerate children async to be less fragile -- rewrite enumerate children async to be less fragile #3571
• Fix weird trailing message in default os check. -- Fix weird trailing message in default os check. #3591

general changes and refactorings

• pin: use separate dagservice for storing pinsets -- pin: use separate dagservice for storing pinsets #3103
• cli: refactor to expose argument parsing functionality -- cli: refactor to expose argument parsing functionality #3308
• Revert "http api: makes sure header is sent even when r is not ready … -- Revert "http api: makes sure header is sent even when r is not ready … #3366
• Create a FilestoreNode object to carry PosInfo -- Create a FilestoreNode object to carry PosInfo #3314
• swarm/peers: print 'n/a' instead of zero latency -- swarm/peers: print 'n/a' instead of zero latency #3491
• blockstore: fix PutMany with cache logic -- blockstore: fix PutMany with cache logic #3162
• Add DAGService.GetLinks() method and use it in the GC and elsewhere. -- Add DAGService.GetLinks() method and use it in the GC and elsewhere. #3255
• Create a write-through block service -- Create a write-through block service #3294
• make path resolver no longer require whole node for construction -- make path resolver no longer require whole node for construction #3321
• Distinguish between Offline and Local Mode. -- Distinguish between Offline and Local Mode. #3259
• Separate out the G.C. Locking from the Blockstore interface. -- Separate out the G.C. Locking from the Blockstore interface. #3348
• ds-help: avoid unnecessary allocs when posssible and make use of RawKey -- ds-help: avoid unnecessary allocs when posssible and make use of RawKey #3407
• Use NextSync method in Datastore -- Use NextSync method in Datastore #3386
• Switch unixfs.Metadata.MimeType to optional -- Switch unixfs.Metadata.MimeType to optional #3458
• blockservice: avoid using unnecessary continue statement -- blockservice: avoid using unnecessary continue statement #3590
• "ipfs name publish": use path.ParsePath instead of casting input -- "ipfs name publish": use path.ParsePath instead of casting input #3592
• Fix inconsistent ipfs stats bw formatting -- Fix inconsistent ipfs stats bw formatting #3554
• Clean up minor issues in 0.4.5 cr. -- Clean up minor issues in 0.4.5 cr. #3562
• set the agent version based on version string -- set the agent version based on version string #3569
• make: unsilence gx -- make: unsilence gx #3586

bsd

• dist_get: Explicitly specify the input file to tar with "-f -" -- Explicitly specify the input file to tar with "-f -" #3264
• ulimit: Tune resource limits on BSDs -- Tune resource limits on BSDs #3374
• ulimit: handle freebsd ulimit code separately from the rest of the un… -- ulimit: handle freebsd ulimit code separately from the rest of the un… #3450

metrics

• metrics: introduce go-metrics-interface -- metrics: introduce go-metrics-interface #3189
• Fix metrics injection -- Fix metrics injection #3315

misc

• Ipfs 0.4.5, pre-release 2 -- Ipfs 0.4.5, pre-release 2 #3623
• bump go requirement to 1.7 -- bump go requirement to 1.7 #3111
• Merge 0.4.3 release candidate changes back into master -- Merge 0.4.3 release candidate changes back into master #3248
• changelog: update for 0.4.3 -- changelog: update for 0.4.3 #3249
• changelog: fix 0.4.3-rc dates -- changelog: fix 0.4.3-rc dates #3358
• changelog: add 0.4.4 -- changelog: add 0.4.4 #3497
• bump dev version to 0.4.5 -- bump dev version to 0.4.5 #3298
• assets: add security@ipfs.io GPG key -- assets: add security@ipfs.io GPG key #2997
• Change LICENSE year -- Change LICENSE year #3145
• Updated authors doc -- Updated authors doc #2800
• pm: Reverse label numbers -- Reverse label numbers #3146
• Cleanup makefiles -- Cleanup makefiles #2999
• use $(MAKE) instead of 'make' in Makefiles (follow-up to f3dc11c) -- use $(MAKE) instead of 'make' in Makefiles (follow-up to f3dc11c) #3265
• Refactoring install.sh -- Refactoring install.sh #3194
• Add check if go code is formatted -- Add check if go code is formatted #3421
• gx: fix dvcsimport path in package.json -- gx: fix dvcsimport path in package.json #3217
• bin: dist_get script: prevents get_go_vars() returns same values twice -- bin: dist_get script: prevents get_go_vars() returns same values twice #3079
• Resort imports in core/core.go -- Resort imports in core/core.go #3395

deps

• Update libp2p to have fixed spdystream dep -- Update libp2p to have fixed spdystream dep #3210
• update libp2p and dht packages -- update libp2p and dht packages #3263
• update to libp2p 4.0.1 and propogate other changes -- update to libp2p 4.0.1 and propogate other changes #3284
• update to libp2p 4.0.4 -- update to libp2p 4.0.4 #3361
• Update go-libp2p across codebase -- Update go-libp2p across codebase #3406
• update to go-libp2p 4.1.0 -- update to go-libp2p 4.1.0 #3373
• update deps for libp2p 3.4.0 -- update deps for libp2p 3.4.0 #3110
• update go-libp2p-swarm with deadlock fixes -- update go-libp2p-swarm with deadlock fixes #3339
• update to new cid and ipld node packages -- update to new cid and ipld node packages #3326
• update to newer ipld node interface with Copy and better Tree -- update to newer ipld node interface with Copy and better Tree #3391
• update experimental go-multiplex to 0.2.6 -- update experimental go-multiplex to 0.2.6 #3475
• use floodsub version 0.8.1 -- use floodsub version 0.8.1 #3402
• bubble up go-datastore deps -- bubble up go-datastore deps #3438
• Update go-ds-measure to 1.1.0 -- Update go-ds-measure to 1.1.0 #3502
• Update goprocess dependency to 1.0.0 -- Update goprocess dependency to 1.0.0 #3260
• routing: rework interfaces to make separation easier -- routing: rework interfaces to make separation easier #3107
• routing: use extracted dht and routing code -- routing: use extracted dht and routing code #3220
• dht: update to dht code with fixed GetClosestPeers -- dht: update to dht code with fixed GetClosestPeers #3346
• deps: move go-is-domain to gx -- deps: move go-is-domain to gx #3077
• Extract blocks/key to ipfs/go-key -- Extract blocks/key to ipfs/go-key #3198
• Extract thirdparty/loggables and thirdparty/peerset -- Extract thirdparty/loggables and thirdparty/peerset #3204
• completely remove go-key dep -- completely remove go-key dep #3439
• remove randbo dep, its no longer needed -- remove randbo dep, its no longer needed #3118
• update to the correct ipld cbor code -- update to the correct ipld cbor code #3616
• update dht code to drop error log to warning -- update dht code to drop error log to warning #3611
• update go-libp2p with negotiate lazy fixes -- update go-libp2p with negotiate lazy fixes #3582
• update libp2p for identify configuration updates -- update libp2p for identify configuration updates #3539
• Use newer flatfs sharding scheme -- Use newer flatfs sharding scheme #3608

testing

• Improve test coverage all over the
• ipfs-test-lib: fix test_fsh arg quoting -- ipfs-test-lib: fix test_fsh arg quoting #3085
• test: 100% coverage for blocks/blocksutil -- test: 100% coverage for blocks/blocksutil #3090
• test: 100% coverage on blocks/set -- test: 100% coverage on blocks/set #3084
• test: 81% coverage on blockstore -- test: 81% coverage on blockstore #3074
• test: reach 80% coverage of unixfs/mod -- test: reach 80% coverage of unixfs/mod #3096
• test: 82% coverage on blocks -- test: 82% coverage on blocks #3086
• Test: unixfs @ 87% coverage -- Test: unixfs @ 87% coverage #3492
• Test/routing/offline -- Test/routing/offline  #3516
• Add test for flags package -- Add test for flags package #3449
• improve test coverage on merkledag package -- improve test coverage on merkledag package #3113
• test: 80% coverage of unixfs/io [WIP] -- test: 80% coverage of unixfs/io [WIP] #3097
• test: accept more than one digit in repo version tests -- test: accept more than one digit in repo version tests #3130
• sharness: fix typo in hash in t0050 -- sharness: fix typo in hash in t0050 #3170
• sharness: don't run go-ipfs instance with default config -- sharness: don't run go-ipfs instance with default config #3526
• trying to debug random test failures -- trying to debug random test failures #3242
• add test to be run to detect future regressions in pinsets -- add test to be run to detect future regressions in pinsets #3302
• Report coverage to coveralls -- Report coverage to coveralls #3460
• Do not include core/commands in coverage report -- Do not include core/commands in coverage report #3466
• Switch coverage to codecov from coveralls -- Switch coverage to codecov from coveralls #3473
• Do not require CI to pass for coverage -- Do not require CI to pass for coverage #3474
• Add multiple small tests -- Add multiple small tests #3477
• Add test for 'ipfs config replace' -- Add test for 'ipfs config replace' #3073
• fix bug in pinsets and add a stress test for the scenario -- fix bug in pinsets and add a stress test for the scenario #3273
• Fix/random repo test failure -- Fix/random repo test failure #3619
• test: add test for invalid routing option -- test: add test for invalid routing option #3584
• test: add test for dag service doing short circuit for raw.Links() -- test: add test for dag service doing short circuit for raw.Links() #3583

docs

• Update dns help with a correct domain name -- Update dns help with a correct domain name #3087
• Add period to ipfs pin rm -- Add period to ipfs pin rm #3088
• Make all Taglines use imperative mood -- Make all Taglines use imperative mood #3041
• Document listing commands better -- Document listing commands better #3083
• readme: add notes on building for uncommon systems -- readme: add notes on building for uncommon systems #3051
• docs: add branch naming conventions -- docs: add branch naming conventions #3035
• commands: replace keyword with <> -- commands: replace <default> keyword with <<default>> #3129
• Doc/cmds/log notice unused -- Doc/cmds/log notice unused #3160
• coreunix: fix Add() docs regarding pinning -- coreunix: fix Add() docs regarding pinning #3513
• README.md: Add sudo to install commands. -- README.md: Add sudo to install commands. #3201
• Edit issue reporting guides -- Edit issue reporting guides #3006
• readme: add -u to gx install commands in manual build instructions -- readme: add -u to gx install commands in manual build instructions #3236
• contribute.md: fix broken link to 'ammending commits' doc. -- contribute.md: fix broken link to 'ammending commits' doc. #3281
• readme: fix go get invocations -- readme: fix go get invocations #3288
• Added note about error codes -- Added note about error codes #2915
• docs: decapitalize IPFS where possible -- docs: decapitalize IPFS where possible #2911
• Add docs for "commands".Command.Run -- Add docs for "commands".Command.Run #3382
• Fix help typo -- Fix typo #3393
• Add default True to files flush -- Add default True to files flush #3167
• Put config keys in proper case -- Put config keys in proper case #3365
• add a note about ipfs key in the main helptext -- add a note about ipfs key in the main helptext #3580
• Fix link in ipfs stats bw help message -- Fix link in ipfs stats bw help message #3620

[whyrusleeping]

Some notes i took while going through and reviewing all this:

• unixfs/format_test.go, 7b16a8d, TestMetedata name typo
• 58a2c5f, no test for invalid routing option error message
• 38703a8, unnecessarily changed formatting in proto file
• 650eeee, not sure we want to completely silence gx install output
• 805b504, 'ipfs key list' should also list key hash ID (perhaps with an option)
• core/commands/publish.go, should use path.ParsePath instead of simply casting input to path.Path
• e76b14a, looks like @Kubuxu manually edited the package.json resulting in weird formatting (Was later fixed)
• 1b3158f, a few trailing spaces in t0180-pubsub.sh
• 8ee4280, potentially unnecessary change in generated protobuf struct tags adding 'name=XYZ' fields
• ba383ed, trailing whitespace, @kevina do you have go-fmt on save setup?
• 1fd99da, unixfs/io/pbdagreader.go, in default case of NewPBFileReader I would prefer to expand the error checking out
• 1e3b4ae, default os check case leaves a weird trailing message, also no tests for empty multiaddr (protocols == 0) thing
• 43320e1, would prefer the defer'ed dr.Close() happens after the switch, not a big deal though
• 396c629, need more tests around Tree and Copy methods for protonode
• aae9eb7, weird that merge commit has changes in it...
• c618698, would be nice to have a test that reproduces the issue this revert fixes (maybe using curl?)
• c31e4f7, not sure if we have tests for the context cancelling in the gateway. We should make sure to add these once this gets extracted
• 4a029c7, need tests for swarm peers verbose mode
• bfe7ad7, should probably add a test here that lists links of a raw object that we don't have
• 02aa6b4, should no longer need null import. This is a holdover from Godeps aggressively removing things
  • lgierth: this null import exists so that gx doesn't forget this dependency. has happened twice in the past :)
• b78b29c, tests for routing resolver failure cases might be nice. Do we have a good mock routing system?
• 8ce9963, did i purposely remove an apostrophe from a comment in a sharness test?
• 48f7e14, should add a test for 'ipfs ls' on a dir with raw nodes in it
• 01aee44, in the future, do name changes in one commit, and restructuring in another
• 1173c00, in AddBlocks, append to array 'if !has' to avoid using extra flow control structures
• Aside: we should think about separating 'providing' from 'giving a block to bitswap'. This will make it easier to address the providers problem moving forward
• f4d7369, should have caught the 'not sending fullness in wantlists' bug here, need better CR
• Note: when parsing a CID fails, we should return a better error message than 'unrecognized multibase encoding' or whatever it is we're spewing now
• cb3bda7, oh boy. This one got lots of review i remember. Still worth everyone taking another look at it
• bf80213, we still need to get around to refactoring the 'node state' things, offline, epehemeral, etc

[whyrusleeping]

Important to look at for @jbenet are the bitswap message sender change (to support cids, bitswap 1.1.0 and 1.0.0) and the merkledag dagservice changes to support cbor nodes, raw nodes, and the original protobufs

[kevina]

@whyrusleeping, if you want go through and create pull requests to fix most of these issues, let me know.

[kevina]

8ce9963, did i purposely remove an apostrophe from a comment in a sharness test?

yes, and I even mentioned it to you, something about about it causing problems with your editor :)

[whyrusleeping]

I'm a dolt

[kevina]

I'm a dolt

Do you want me to fix it?

[whyrusleeping]

That might be a very difficult problem to fix, you can try.

[kevina]

@whyrusleeping, I meant add back the apostrophe. :) I am fixing minor formatting/spelling issues now.

[kevina]

38703a8, unnecessarily changed formatting in proto file

don't see the problem other than diff noise, the changes help with consistency

unixfs/format_test.go, 7b16a8d, TestMetedata name typo
1b3158f, a few trailing spaces in t0180-pubsub.sh
8ce9963, did i purposely remove an apostrophe from a comment in a sharness test?

fixed in pr #3562

ba383ed, trailing whitespace, @kevina do you have go-fmt on save setup?

Already fixed, sorry.

8ee4280, potentially unnecessary change in generated protobuf struct tags adding 'name=XYZ' fields

this was talked about in the issue

[kevina]

I edited @whyrusleeping to be check boxes and checked resolved problems are ones where there is nothing to do. Github has no edit history and also there is no notification sent when an edit is made so I will continue to add notes on items in separate comments.

[kevina]

48f7e14, should add a test for 'ipfs ls' on a dir with raw nodes in it

Now fixed.

bfe7ad7, should probably add a test here that lists links of a raw object that we don't have

Your right. There is an issue for that.

[Kubuxu]

bfe7ad7, should probably add a test here that lists links of a raw object that we don't have

in #3583

58a2c5f, no test for invalid routing option error message

in #3584

43320e1, would prefer the defer'ed dr.Close() happens after the switch, not a big deal though

in #3585

e76b14a, looks like @Kubuxu manually edited the package.json resulting in weird formatting (Was later fixed)

Probably while resolving merge conflict

[Kubuxu]

43320e1, would prefer the defer'ed dr.Close() happens after the switch, not a big deal though

The close has to be where it is, due to one more error code that continues function flow but returns nil DagReader.

[kevina]

805b504, 'ipfs key list' should also list key hash ID (perhaps with an option)

#3581

[kevina]

1173c00, in AddBlocks, append to array 'if !has' to avoid using extra flow control structures

#3590

[kevina]

I have checked off all points that are either already addressed or are in an open p.r. I will look into the following remaining issues:

core/commands/publish.go, should use path.ParsePath instead of simply casting input to path.Path
1fd99da, unixfs/io/pbdagreader.go, in default case of NewPBFileReader I would prefer to expand the error checking out
1e3b4ae, default os check case leaves a weird trailing message, also no tests for empty multiaddr (protocols == 0) thing

What remains are some test, I might look into those after I address the above, but they are also testing parts of the code I am not familiar with so I am not sure how qualified I am to write them.

[kevina]

core/commands/publish.go, should use path.ParsePath instead of simply casting input to path.Path

#3592

1fd99da, unixfs/io/pbdagreader.go, in default case of NewPBFileReader I would prefer to expand the error checking out

I am unsure what you are after here.

1e3b4ae, default os check case leaves a weird trailing message, also no tests for empty multiaddr (protocols == 0) thing

Fixed the first part in #3591. Not 100% sure what you are after in the second part.

[ghost]

I updated the list in the top comment -- 22 items added, for a total of now 199 changes. added:

misc

• Ipfs 0.4.5, pre-release 2 -- Ipfs 0.4.5, pre-release 2 #3623

deps

• update to the correct ipld cbor code -- update to the correct ipld cbor code #3616
• update dht code to drop error log to warning -- update dht code to drop error log to warning #3611
• update go-libp2p with negotiate lazy fixes -- update go-libp2p with negotiate lazy fixes #3582
• update libp2p for identify configuration updates -- update libp2p for identify configuration updates #3539
• Use newer flatfs sharding scheme -- Use newer flatfs sharding scheme #3608

ipld

• Fix "ipfs ls" so it works correctly with raw leaves. -- Fix "ipfs ls" so it works correctly with raw leaves. #3557

docs

• add a note about ipfs key in the main helptext -- add a note about ipfs key in the main helptext #3580
• Fix link in ipfs stats bw help message -- Fix link in ipfs stats bw help message #3620

general

• blockservice: avoid using unnecessary continue statement -- blockservice: avoid using unnecessary continue statement #3590
• "ipfs name publish": use path.ParsePath instead of casting input -- "ipfs name publish": use path.ParsePath instead of casting input #3592
• Fix inconsistent ipfs stats bw formatting -- Fix inconsistent ipfs stats bw formatting #3554
• Clean up minor issues in 0.4.5 cr. -- Clean up minor issues in 0.4.5 cr. #3562
• set the agent version based on version string -- set the agent version based on version string #3569
• make: unsilence gx -- make: unsilence gx #3586

fixes

• rewrite enumerate children async to be less fragile -- rewrite enumerate children async to be less fragile #3571
• Fix weird trailing message in default os check. -- Fix weird trailing message in default os check. #3591

testing

• Fix/random repo test failure -- Fix/random repo test failure #3619
• test: add test for invalid routing option -- test: add test for invalid routing option #3584
• test: add test for dag service doing short circuit for raw.Links() -- test: add test for dag service doing short circuit for raw.Links() #3583

features

• add in option to use nil-routing -- add in option to use nil-routing #3605
• "ipfs key list": include the hash of the key id in addition to the name -- "ipfs key list": include the hash of the key id in addition to the name #3581

[whyrusleeping]

closing this now