blockstore: fix PutMany with cache logic #3162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
your tests are broken and stuff |
| // to reduce number of puts we need conclusive infomration if block is contained | ||
| // this means that PutMany can't be improved with bloom cache so we just | ||
| // just do a passthrough. | ||
| return b.blockstore.PutMany(bs) |
There was a problem hiding this comment.
I have to add all blocks to bloom....
Will add a test case.
Kubuxu
force-pushed
the
fix/bs/many-caching-fix
branch
3 times, most recently
from
515c771
to
6e52419
Compare
Kubuxu
added
need/review
|
@whyrusleeping should be fixed, travis is queued up and previously it was having network problems. |
Thanks @whyrusleeping for noticing it. Removed PutMany logic in bloom cache as it can't help with anything. Fixed ARC cache to use filtered results instad of all blocks. License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
Kubuxu
force-pushed
the
fix/bs/many-caching-fix
branch
from
6e52419
to
d080ff1
Compare
|
LGTM, thanks for fixing :) |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @whyrusleeping for noticing it.
Removed PutMany logic in bloom cache as it can't help with anything.
Fixed ARC cache to use filtered results instead of all blocks.
Also add test case for it.