Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/routing/offline #3516

Merged
merged 3 commits into from
Dec 17, 2016
Merged

Conversation

zmackie
Copy link
Contributor

@zmackie zmackie commented Dec 17, 2016

PR for the ongoing coverage effort (#3053).

This PR creates tests for the offline routing package and puts coverage at %78.9. I'm putting together a PR next week to remove some of the cruft in this package (FindProviders) at which point coverage will be at %81.1.

License: MIT
Signed-off-by: Zander Mackie <zmackie@gmail.com>
License: MIT
Signed-off-by: Zander Mackie <zmackie@gmail.com>
License: MIT
Signed-off-by: Zander Mackie <zmackie@gmail.com>
Copy link
Member

@whyrusleeping whyrusleeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, thanks again @Zanadar !

@whyrusleeping whyrusleeping merged commit 548490f into ipfs:master Dec 17, 2016
@ghost ghost mentioned this pull request Dec 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants