Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Bash complete script #3377

Merged
merged 1 commit into from
Nov 15, 2016
Merged

Updated Bash complete script #3377

merged 1 commit into from
Nov 15, 2016

Conversation

EliasGabrielsson
Copy link
Contributor

Some minor bug still exist but not breaking.
Everything is marked with "TODO" inline the script.

License: MIT
Signed-off-by: Elias Gabrielsson elias@benefactory.se

Some minor bug still exist but not breaking.
Everything is marked with "TODO" inline the script.

License: MIT
Signed-off-by: Elias Gabrielsson <elias@benefactory.se>
@EliasGabrielsson
Copy link
Contributor Author

Replacing old pull request. @Kubuxu

@Kubuxu
Copy link
Member

Kubuxu commented Nov 15, 2016

Hmm, zsh has bash completion compat, which means that I can give it actual use test. I will use it for 1-2 days and get back to you.

Thanks again.

@Kubuxu
Copy link
Member

Kubuxu commented Nov 15, 2016

Looks like it doesn't work well for complex completions so I will just run it in bash and test out.

@Kubuxu
Copy link
Member

Kubuxu commented Nov 15, 2016

LGTM, only thing that I observed is that it doesn't support short options -r vs --recursive and so on but either way it is much much better than current completion.

Thank you very much.

@whyrusleeping good for merge.

@Kubuxu Kubuxu added the RFM label Nov 15, 2016
@EliasGabrielsson
Copy link
Contributor Author

I have intentionally not implemented short option. It's not a big deal to implement if its needed.

@Kubuxu
Copy link
Member

Kubuxu commented Nov 15, 2016

Nah, I think in the bash's completion method it might cause more confusion than good.

@Kubuxu Kubuxu assigned whyrusleeping and unassigned Kubuxu Nov 15, 2016
@whyrusleeping
Copy link
Member

Alright cool, will be good to finally have this in.

@whyrusleeping whyrusleeping merged commit e4be1b2 into ipfs:master Nov 15, 2016
@EliasGabrielsson
Copy link
Contributor Author

Under the development of the complete-script I have wonder how the script could be installed in an easy fashion way.

ipfs autocomplete install - or similar,
a) Search for current shell, eg. bash / zsh.
b) Search if there is a script available somewhere. How does ipfs update work, does it fetch things from github or by ipfs itself? Is version mapped to github versions?
c) Install script on default location based on OS and profilesettings. This can be tricky but I think its do able. An option could be to specify install location.

The ipfs-install could also keep track if the script have been installed and autoupdate it when ipfs gets updated by ipfs-install

What do you think?

@Kubuxu
Copy link
Member

Kubuxu commented Nov 16, 2016

Usually it is package mangers that do this and I think it is good enough.

@ghost ghost mentioned this pull request Dec 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants