dag/get: accept paths and not just cids #3517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Jeromy <why@ipfs.io>
Kubuxu
approved these changes
Dec 17, 2016
License: MIT Signed-off-by: Jeromy <why@ipfs.io>
|
LGTM 👍 It should also get support for proper paths once we've figured out which namespace to use. |
|
Actually this doesn't resolve #3500 since it only supports |
|
@lgierth does |
|
@lgierth No, this totally works: https://github.com/ipfs/go-ipfs/blob/master/path/path.go#L95 |
|
Uggh sorry, I must have used the wrong binary again... > ipfs dag get /ipfs/$(echo foo | ipfs add -q)
{"data":"CAISBGZvbwoYBA==","links":[]}
> ipfs dag get /ipns/ipfs.io/theme
Error: selected encoding not supportedI was pretty sure I got the same error with /ipfs too -- all good now! 👍 |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3500
License: MIT
Signed-off-by: Jeromy why@ipfs.io