The conquest of El Cid, Pt. 2 #3290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
weird... for some reason the gx install is getting skipped on the osx sharness builds... uhhh |
|
Was a weird CI fluke. moving on. |
|
@whyrusleeping I just know that once this is merged it going to create another round of not so nice conflicts for me to resolve in #2634 🙁 |
|
@kevina it shouldnt be too bad. I can handle them if you like. The biggest thing to keep in mind is that you won't be able to compare keys/cids with |
License: MIT Signed-off-by: Jeromy <why@ipfs.io>
whyrusleeping
force-pushed
the
feat/el-cid-2
branch
from
02d233a
to
282bdc4
Compare
whyrusleeping
referenced
this pull request
Oct 9, 2016
this redoes (again) 582e5de. License: MIT Signed-off-by: Kevin Atkinson <k@kevina.org>
|
@whyrusleeping I'm curious what this is, besides a ridiculously long epic poem about a Spaniard. What does Cid stand for, and why is it replacing multihash everywhere? |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
License: MIT
Signed-off-by: Jeromy why@ipfs.io